indicate settings that need a mission restart #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to work. |
dedmen
approved these changes
Jul 23, 2018
|
Is that good enough? 😂 🔨 |
PabstMirror
reviewed
Jul 23, 2018
addons/settings/script_component.hpp
Outdated
| @@ -108,8 +115,9 @@ | |||
| #define GET_TEMP_NAMESPACE_VALUE(setting,source) (GET_TEMP_NAMESPACE(source) getVariable [setting, [nil, nil]] select 0) | |||
| #define GET_TEMP_NAMESPACE_PRIORITY(setting,source) (GET_TEMP_NAMESPACE(source) getVariable [setting, [nil, nil]] select 1) | |||
|
|
|||
| #define SET_TEMP_NAMESPACE_VALUE(setting,value,source) (GET_TEMP_NAMESPACE(source) setVariable [setting, [value, GET_TEMP_NAMESPACE_PRIORITY(setting,source)]]) | |||
| #define SET_TEMP_NAMESPACE_PRIORITY(setting,priority,source) (GET_TEMP_NAMESPACE(source) setVariable [setting, [GET_TEMP_NAMESPACE_VALUE(setting,source), priority]]) | |||
| #define SET_TEMP_NAMESPACE_AWAITING_RESTART(setting) if (toLower setting in GVAR(needRestart)) then {GVAR(awaitingRestartTemp) pushBackUnique toLower setting} | |||
There was a problem hiding this comment.
Maybe we could skip showing in 3den
#define SET_TEMP_NAMESPACE_AWAITING_RESTART(setting) if ((toLower setting in GVAR(needRestart)) && {!is3den}) then {GVAR(awaitingRestartTemp) pushBackUnique toLower setting}
PabstMirror
approved these changes
Jul 23, 2018
There was a problem hiding this comment.
Combination of this and #952 give some great color-based feedback as to what settings are doing
ViperMaul
added a commit
that referenced
this pull request
Jul 27, 2018
* origin/master: XEH - Compatiblity for Encore (1.84) (#953) indicate settings that need a mission restart (#894) don't skip next PFH if current one is removed while iterating through (#950) change color of name of temporarily changed settings (#952) handle input gracefully in keybinding editKey ui function (#951) Update fnc_deleteEntity.sqf (#949)
|
@commy2 - Should the icon also change when the setting is changed, not just override checkboxes? |
|
It should be shown when either the setting is changed, or the settings priority is changed, or both I'd say. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
needs testing >.<