Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change color of name of temporarily changed settings #952

Merged
merged 3 commits into from
Jul 23, 2018
Merged

change color of name of temporarily changed settings #952

merged 3 commits into from
Jul 23, 2018

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Jul 3, 2018 •
edited
Loading

When merged this pull request will:

  • This will make the names of settings that were changed by ui appear yellow, which helps when editing settings in bulk. Serves as a reminder which settings will be changed once OK is pressed, which changes will be discarded once Cancel is pressed.

Needs testing, don't have Arma for 2 weeks.

@commy2 commy2 added this to the 3.8 milestone Jul 3, 2018
@commy2
Copy link
Contributor Author

commy2 commented Jul 4, 2018

Tested. Now appears to work.

kymckay
kymckay approved these changes Jul 23, 2018
View reviewed changes
Copy link
Contributor

@kymckay kymckay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@commy2 commy2 merged commit 8eaac30 into master Jul 23, 2018
@commy2 commy2 deleted the colorTempChangedSettings branch July 23, 2018 10:00
ViperMaul added a commit that referenced this pull request Jul 27, 2018
@ViperMaul
Merge remote-tracking branch 'origin/master' into v3.8.0.180701
0dd4d34 
* origin/master:
  XEH - Compatiblity for Encore (1.84) (#953)
  indicate settings that need a mission restart (#894)
  don't skip next PFH if current one is removed while iterating through (#950)
  change color of name of temporarily changed settings (#952)
  handle input gracefully in keybinding editKey ui function (#951)
  Update fnc_deleteEntity.sqf (#949)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kymckay kymckay kymckay approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
3.8
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@commy2 @kymckay