Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

German translation, part 2 #980

Merged
merged 4 commits into from
Sep 17, 2018
Merged

German translation, part 2 #980

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
87d4eac
German translation, part 2
commy2 Sep 14, 2018
22f22a2
translation fixes
commy2 Sep 14, 2018
8ff4361
translation fixes
commy2 Sep 15, 2018
c579c67
translation fixes
commy2 Sep 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions addons/keybinding/stringtable.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<Package name="Keybinding">
<Key ID="STR_CBA_Keybinding_Component">
<English>Community Base Addons - Keybinding</English>
<German>Community Base Addons - Tastenbelegung</German>
<Japanese>Community Base Addons - キー割り当て</Japanese>
<Chinese>社群基礎模組 - 按鍵綁定</Chinese>
<Chinesesimp>社群基础模组 - 按键绑定</Chinesesimp>
Expand Down
3 changes: 3 additions & 0 deletions addons/main/stringtable.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
</Key>
<Key ID="STR_CBA_URL">
<English>https://www.github.com/CBATeam/CBA_A3</English>
<German>https://www.github.com/CBATeam/CBA_A3</German>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just simply use a single entry here as every entry is literally the same

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a string so it can be changed if needed everywhere at once, while not having to use a macro which would have character escaping issues. It is translated I guess mainly so Jonpas' translation counter bot says 100% eventually.

Copy link
Member

@jonpas jonpas Sep 14, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flummi's bot. ;)
But yes.

Best to just throw that under all supported languages, so bot picks them all up and counts them.

<Japanese>https://www.github.com/CBATeam/CBA_A3</Japanese>
<Chinese>https://www.github.com/CBATeam/CBA_A3</Chinese>
<Chinesesimp>https://www.github.com/CBATeam/CBA_A3</Chinesesimp>
Expand All @@ -24,6 +25,7 @@
</Key>
<Key ID="STR_CBA_Main_Component">
<English>Community Base Addons - Main Component</English>
<German>Community Base Addons - Hauptkomponente</German>
<Japanese>Community Base Addons - メイン要素</Japanese>
<Chinese>社群基礎模組 - 主要組件</Chinese>
<Chinesesimp>社群基础模组 - 主要组件</Chinesesimp>
Expand All @@ -34,6 +36,7 @@
</Key>
<Key ID="STR_CBA_Optional_Component">
<English>Community Base Addons - Optional Component</English>
<German>Community Base Addons - Optionale Komponente</German>
<Japanese>Community Base Addons - オプション要素</Japanese>
<Chinese>社群基礎模組 - 可選組件</Chinese>
<Chinesesimp>社群基础模组 - 可选组件</Chinesesimp>
Expand Down
1 change: 1 addition & 0 deletions addons/music/stringtable.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<Package name="Keybinding">
<Key ID="STR_cba_music_Component">
<English>Community Base Addons - Music</English>
<German>Community Base Addons - Musik</German>
<Japanese>Community Base Addons - 音楽</Japanese>
<Chinese>社群基礎模組 - 音樂</Chinese>
<Chinesesimp>社群基础模组 - 音乐</Chinesesimp>
Expand Down
1 change: 1 addition & 0 deletions addons/network/stringtable.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<Package name="Network">
<Key ID="STR_CBA_Network_Component">
<English>Community Base Addons - Network</English>
<German>Community Base Addons - Netzwerk</German>
<Japanese>Community Base Addons - ネットワーク</Japanese>
<Chinese>社群基礎模組 - 網路</Chinese>
<Chinesesimp>社群基础模组 - 网路</Chinesesimp>
Expand Down
1 change: 1 addition & 0 deletions addons/settings/stringtable.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<Package name="Settings">
<Key ID="STR_cba_settings_Component">
<English>Community Base Addons - Settings Component</English>
<German>Community Base Addons - Einstellungskomponente</German>
Copy link
Contributor

@dedmen dedmen Sep 14, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This says component. But music/network/strings/UI/Vectors/Versioning just don't.
Community Base Addons - Einstellungen ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this more. Should I change it in English as well?

<Japanese>Community Base Addons - 設定要素</Japanese>
<Chinese>社群基礎模組 - 設定組件</Chinese>
<Chinesesimp>社群基础模组 - 设定组件</Chinesesimp>
Expand Down
1 change: 1 addition & 0 deletions addons/statemachine/stringtable.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<Package name="Statemachine">
<Key ID="STR_cba_statemachine_Component">
<English>Community Base Addons - State Machine Component</English>
<German>Community Base Addons - State Machine-Komponente</German>
<Japanese>Community Base Addons - ステート マシーン要素</Japanese>
<Chinese>社群基礎模組 - 狀態機組件</Chinese>
<Chinesesimp>社群基础模组 - 状态机组件</Chinesesimp>
Expand Down
3 changes: 2 additions & 1 deletion addons/strings/stringtable.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<Package name="Strings">
<Key ID="STR_CBA_Strings_Component">
<English>Community Base Addons - Strings</English>
<German>Community Base Addons - Strings</German>
<Japanese>Community Base Addons - ストリングス</Japanese>
<Chinese>社群基礎模組 - 字串</Chinese>
<Chinesesimp>社群基础模组 - 字串</Chinesesimp>
Expand All @@ -28,7 +29,7 @@
<Key ID="STR_CBA_FORMAT_NUMBER_THOUSANDS_SEPARATOR">
<English>,</English>
<Czech> </Czech>
<German> </German>
<German>.</German>
<Polish> </Polish>
<Russian> </Russian>
<French> </French>
Expand Down
1 change: 1 addition & 0 deletions addons/ui/stringtable.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<Package name="Ui">
<Key ID="STR_CBA_Ui_Component">
<English>Community Base Addons - User Interface</English>
<German>Community Base Addons - Benutzeroberfläche</German>
<Japanese>Community Base Addons - ユーザー インターフェイス</Japanese>
<Chinese>社群基礎模組 - 使用者介面</Chinese>
<Chinesesimp>社群基础模组 - 使用者介面</Chinesesimp>
Expand Down
1 change: 1 addition & 0 deletions addons/vectors/stringtable.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<Package name="Vectors">
<Key ID="STR_CBA_Vectors_Component">
<English>Community Base Addons - Vectors</English>
<German>Community Base Addons - Vektoren</German>
<Japanese>Community Base Addons - ベクター</Japanese>
<Chinese>社群基礎模組 - 向量</Chinese>
<Chinesesimp>社群基础模组 - 向量</Chinesesimp>
Expand Down
1 change: 1 addition & 0 deletions addons/versioning/stringtable.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<Package name="Versioning">
<Key ID="STR_CBA_Versioning_Component">
<English>Community Base Addons - Versioning</English>
<German>Community Base Addons - Versionierung</German>
<Japanese>Community Base Addons - バージョニング</Japanese>
<Chinese>社群基礎模組 - 版本</Chinese>
<Chinesesimp>社群基础模组 - 版本</Chinesesimp>
Expand Down
1 change: 1 addition & 0 deletions addons/xeh/stringtable.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<Package name="XEH">
<Key ID="STR_CBA_XEH_Component">
<English>Community Base Addons - Extended Event Handlers</English>
<German>Community Base Addons - Erweiterte Ereignishandler</German>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ereignisbehandlung

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently it's a toss up: https://www.dict.cc/english-german/event+handler.html

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't translate this at all since it's a code thing. You didn't translate strings to "Zeichenketten" either.

Copy link
Contributor

@bux bux Sep 15, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just be consistent.

https://help.sap.com/doc/abapdocu_752_index_htm/7.52/de-DE/abenevent_handler_glosry.htm
https://de.wikipedia.org/wiki/Ereignis_(Programmierung)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auch die Ereignisbehandlungsroutinen (englisch event handler, deutsch Ereignishandler) und die Ereignisse selbst werden dann als Objekte modelliert.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when you want to keep it then please also translate String to "Zeichenketten"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ done

<Japanese>Community Base Addons - 拡張型イベント ハンドラ</Japanese>
<Chinese>社群基礎模組 - 擴展事件處理器</Chinese>
<Chinesesimp>社群基础模组 - 扩展事件处理器</Chinesesimp>
Expand Down