Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perfusion Alignment fixes #1363

Merged
merged 57 commits into from
Nov 6, 2020
Merged

Perfusion Alignment fixes #1363

merged 57 commits into from
Nov 6, 2020

Conversation

sarthakpati
Copy link
Contributor

Fixes issue #1235

Proposed Changes

  • Perfusion Alignment fixes

@sarthakpati
added new parameter
2ce5a82
@sarthakpati
Merge branch 'master' of https://github.com/CBICA/CaPTk into 1235
2686f81
@sarthakpati
finished CLI, started parsing
d68f7db
@sarthakpati
updated parsing
0c94dad
@sarthakpati
updated example
fbd415f
@sarthakpati
passing all parameters into compute function
77e9822
@sarthakpati
re-enabled the application from CLI
5ec94b3
@sarthakpati
added mask to computation api
4127ce2
@sarthakpati
return mask
4a0a565
@sarthakpati
masking options
c9b6131
@sarthakpati
added new function to calculate std-dev
271ba44
@sarthakpati
iterator added
f0b4759
@sarthakpati
using mask to iterate
419c89b
@sarthakpati
finished the std-dev calculator and using it for "-m 1"
82182a3
@sarthakpati
getting 10th percentile
47bedce
@sarthakpati
mask calculation '1' completed
727d523
@sarthakpati
mask calculation type '2' finished
0341740
@sarthakpati
removed redundant code
3fac462
@sarthakpati
added sanity check
e089fb2
@sarthakpati
added implementation to get the mean curve
85d2a0a
@sarthakpati
updated sanity checks and re-using older implementation for mean
f20d6df
@sarthakpati
using the output resolution provided by user
ba37561
@sarthakpati
no need for redundant comments
66bccb6
@sarthakpati
some typos fixed
b491840
@sarthakpati
redundant code removed
184bd34
@sarthakpati
redundant code removed
dec1d9e
@sarthakpati sarthakpati marked this pull request as draft October 28, 2020 14:21
@sarthakpati sarthakpati changed the title 1235 Perfusion Alignment fixes Oct 28, 2020
@sarthakpati
Merge branch '1364' of https://github.com/sarthakpati/CaPTk into 1235
fc832e5
@sarthakpati
Merge branch '1364' of https://github.com/sarthakpati/CaPTk into 1235
1532910
@sarthakpati
Merge branch 'master' into 1235
86f076d
@sarthakpati
extra percentage was going up
659641d
@sarthakpati
Merge branch '1235' of https://github.com/sarthakpati/CaPTk into 1235
30bdd6f
@sarthakpati
Merge branch 'master' into 1235
7ef4a7c
@sarthakpati
Merge branch 'master' of https://github.com/CBICA/CaPTk into 1235
9ca652a
@sarthakpati
Merge branch '1235' of https://github.com/sarthakpati/CaPTk into 1235
bdc5c78
@sarthakpati
progress bar is being annoying
4e1b487
@sarthakpati
add option to resample across time
b244c42
@sarthakpati
enable 4th dimension resample
7106a4a
@sarthakpati
this is working as expected
c8cc18f
@sarthakpati
output in correct space
92e1306
@sarthakpati
using input time resolution
ed1c82b
@sarthakpati
ensuring the input time resolution is factored in
557cc0c
@sarthakpati
don't want that
f7fef93
@sarthakpati
cleaned up cli
f86cb78
@sarthakpati
extra masking options not needed
98fae8c
@sarthakpati
no need of the last 2 numbers
9a8692d
@sarthakpati
appropriate changes in interface (cli and gui)
9b6b68a
@sarthakpati sarthakpati marked this pull request as ready for review November 5, 2020 16:16
@sarthakpati sarthakpati merged commit 5883f99 into CBICA:master Nov 6, 2020
@sarthakpati sarthakpati deleted the 1235 branch November 6, 2020 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderGetka-cbica AlexanderGetka-cbica AlexanderGetka-cbica approved these changes

@ashishsingh18 ashishsingh18 Awaiting requested review from ashishsingh18

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarthakpati @AlexanderGetka-cbica