Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and Correct API References in ReportStream Responses #16785

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Update and Correct API References in ReportStream Responses #16785

merged 2 commits into from
Dec 17, 2024
+66 −21

Conversation

jpandersen87
Copy link
Collaborator

@jpandersen87 jpandersen87 commented Dec 12, 2024 •
edited
Loading

Fixes #16660

This PR:

  • Makes corrections to documentation within "Responses from ReportStream" section
    • Adds new information about retrieving submission list via api
  • Converts code-element-marked areas to CodeSnippet

@jpandersen87 jpandersen87 self-assigned this Dec 12, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 12, 2024 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@jillian-hammer jillian-hammer self-requested a review December 12, 2024 15:03
jillian-hammer
jillian-hammer approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@jillian-hammer jillian-hammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @jpandersen87 !

victor-chaparro
victor-chaparro approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@victor-chaparro victor-chaparro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpandersen87 jpandersen87 enabled auto-merge (squash) December 17, 2024 15:14
@github-actions GitHub Actions
Copy link

Branch deployed to Chromatic 🚀.

  • ⚠️ Detected 0 tests with visual changes.
  • ✅ All tests passed.

View via:

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jpandersen87 jpandersen87 merged commit 2ae0a61 into main Dec 17, 2024
31 of 33 checks passed
@jpandersen87 jpandersen87 deleted the experience/16660-Update-and-Correct-API-References-in-ReportStream-Responses branch December 17, 2024 16:00
@github-actions GitHub Actions
Copy link

⚠️ Broken Links ⚠️

❌ https://www.cdc.gov/od/foia

Error: Request failed with status code 403

❌ https://www.hhs.gov/vulnerability-disclosure-policy/index.html

Error: Request failed with status code 403

❌ https://www.cdc.gov/poxvirus/mpox/lab-personnel/report-results.html

Error: Request failed with status code 404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jillian-hammer jillian-hammer jillian-hammer approved these changes

@victor-chaparro victor-chaparro victor-chaparro approved these changes

@etanb etanb Awaiting requested review from etanb

Assignees

@jpandersen87 jpandersen87

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update and Correct API References in ReportStream Responses
3 participants
@jpandersen87 @victor-chaparro @jillian-hammer