Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experience/16070/message bank page #16792

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Experience/16070/message bank page #16792

wants to merge 11 commits into from

Conversation

etanb
Copy link
Collaborator

@etanb etanb commented Dec 13, 2024

This PR creates the initial functionality for the Message Testing feature, and completes the following objectives:

  • Create an initial entry point for a user to test messages at the URL: http://localhost:3000/admin/orgreceiversettings/org/${ORG-NAME}/receiver/${RECEIVER-NAME}/action/edit/message-testing
  • Display all messages for an Org
  • Ability to add a custom test message (will only persist within that single browser tab)
  • Ability to open message in a new tab

VIDEO:

messageTesting.mp4

Fixes #16070

@etanb etanb added the experience Team label to flag issues owned by the Experience Team label Dec 13, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2024 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@etanb etanb added the trialfrontend03 Trigger a trialfrontend03 deployment label Dec 13, 2024
@etanb etanb requested a review from jpandersen87 December 16, 2024 23:04
@github-actions GitHub Actions
Copy link

Branch deployed to Chromatic 🚀.

  • ⚠️ Detected 0 tests with visual changes.
  • ✅ All tests passed.

View via:

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
35.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

⚠️ Broken Links ⚠️

❌ https://www.cdc.gov/od/foia

Error: Request failed with status code 403

❌ https://www.hhs.gov/vulnerability-disclosure-policy/index.html

Error: Request failed with status code 403

❌ https://www.cdph.ca.gov/Programs/CID/DCDC/Pages/CalREDIE.aspx

Error: timeout of 10000ms exceeded

❌ https://www.cdc.gov/poxvirus/mpox/lab-personnel/report-results.html

Error: Request failed with status code 404

victor-chaparro
victor-chaparro approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@victor-chaparro victor-chaparro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jillian-hammer
jillian-hammer approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@jillian-hammer jillian-hammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! thanks @etanb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jillian-hammer jillian-hammer jillian-hammer approved these changes

@victor-chaparro victor-chaparro victor-chaparro approved these changes

@jpandersen87 jpandersen87 jpandersen87 approved these changes

Assignees
No one assigned
Labels
experience Team label to flag issues owned by the Experience Team trialfrontend03 Trigger a trialfrontend03 deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Test Message Bank Page
4 participants
@etanb @jpandersen87 @victor-chaparro @jillian-hammer