Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FHIRpath error message, new AOE codes, and zip code fix #16821

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

lucero-v
Copy link
Collaborator

@lucero-v lucero-v commented Dec 17, 2024

This PR contains various small fixes detailed below.

Test Steps:

  1. To test fhirpath error message: run fhir path CLI tool and enter an invalid path such as Bundle.entry.resource.ofType(MessageHeader).extension("https://reportstream.cdc.gov/fhir/StructureDefinition/msh-message-header").extension("MSH.7").value.changetimezone('America/Denver'). The log should display the specific FHIRLexer exception message.
  2. To test zip code fix - run unit test

Changes

  • log detailed message when evaluating fhirpath. Error messages come from FHIRPathEngine.java in fhirpath library
  • trim hyphenated zip codes before doing a lookup on the ZipCode table
  • add AOE codes that were missing in observation-mapping table (already pushed to both staging and prod)

Checklist

Testing

  • Tested locally?
  • Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
  • (For Changes to /frontend-react/...) Ran npm run lint:write?
  • Added tests?

Process

  • Are there licensing issues with any new dependencies introduced?
  • Includes a summary of what a code reviewer should test/verify?
  • Updated the release notes?
  • Database changes are submitted as a separate PR?
  • DevOps team has been notified if PR requires ops support?

Linked Issues

  • Fixes #issue

To Be Done

Create GitHub issues to track the work remaining, if any

  • #issue

@lucero-v lucero-v requested a review from a team as a code owner December 17, 2024 00:15
@lucero-v lucero-v self-assigned this Dec 17, 2024
Copy link

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@lucero-v lucero-v added the onboarding-ops Work related to onboarding with a partner. Addressed by the Onboarding & Operations team in RS. label Dec 17, 2024
@lucero-v lucero-v enabled auto-merge (squash) December 17, 2024 00:16
Copy link

Test Results

1 268 tests  ±0   1 264 ✅ ±0   7m 59s ⏱️ +7s
  164 suites ±0       4 💤 ±0 
  164 files   ±0       0 ❌ ±0 

Results for commit 2d8e390. ± Comparison against base commit 288a70d.

Copy link

sonarcloud bot commented Dec 17, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@lucero-v lucero-v linked an issue Dec 17, 2024 that may be closed by this pull request
4 tasks
Copy link

Integration Test Results

 60 files  ±0   60 suites  ±0   37m 6s ⏱️ - 1m 23s
424 tests ±0  414 ✅ ±0  10 💤 ±0  0 ❌ ±0 
427 runs  ±0  417 ✅ ±0  10 💤 ±0  0 ❌ ±0 

Results for commit 2d8e390. ± Comparison against base commit 288a70d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
onboarding-ops Work related to onboarding with a partner. Addressed by the Onboarding & Operations team in RS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SPIKE] FHIRPath Validation Error Code Improvements
1 participant