Update to Node 18 #7078

[jpandersen87]

This PR updates the node version to the current LTS: 18.13.X. Closes #7078

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[github-actions]

Test Results

692 tests  ±0   688 ✔️ ±0   1m 4s ⏱️ -25s
  88 suites ±0       4 💤 ±0 
  88 files   ±0       0 ❌ ±0 

Results for commit 048659d. ± Comparison against base commit db30584.

[github-actions]

Integration Test Results

120 tests   120 ✔️  2m 9s ⏱️
  12 suites      0 💤
  12 files        0 ❌

Results for commit 048659d.

[stephenkao]

@jpandersen87 Are you running into request proxy issues locally with this upgrade?

Proxy error: Could not proxy request /api/settings/organizations from localhost:3000 to http://localhost:7071.
See https://nodejs.org/api/errors.html#errors_common_system_errors for more information (ECONNREFUSED).

I just checked out to master to verify that it's not happening there 🤔 I'm going to look into the breaking changes to see if anything could potentially be related, but I just wanted to check with you beforehand!

[jpandersen87]

@jpandersen87 Are you running into request proxy issues locally with this upgrade?

Proxy error: Could not proxy request /api/settings/organizations from localhost:3000 to http://localhost:7071.
See https://nodejs.org/api/errors.html#errors_common_system_errors for more information (ECONNREFUSED).

I just checked out to master to verify that it's not happening there 🤔 I'm going to look into the breaking changes to see if anything could potentially be related, but I just wanted to check with you beforehand!

I did not but will check again.

[jpandersen87]

Scratch that, when checking the submissions page after imitating simple_report I get the error. Investigating.

[jpandersen87]

Was an error on my end with the java app not running. Cannot reproduce proxy errors in dev. However, node 18 support seems to be incomplete for our dependency msw: mswjs/msw#1388

[jpandersen87]

There's a hacky workaround mentioned here: mswjs/interceptors#283 (comment) but will not go down that road. We'll have to either wait for full node 18 support or change libraries, but for now this is blocked.

[penny-lischer]

LGTM

[stephenkao]

@jpandersen87 What do you think about closing this for now and reopening when the MSW issue is resolved? Not a big deal, though -- just thinking about keeping the pull request list smaller!

[jpandersen87]

Closing for now