Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Node 18.15 #8631

Merged
merged 12 commits into from
Mar 10, 2023
Merged

Update to Node 18.15 #8631

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4ffa5a1
Update to Node 18
jpandersen87 Mar 7, 2023
923d1e6
docs
jpandersen87 Mar 7, 2023
a1be31a
docs
jpandersen87 Mar 7, 2023
ae1e800
Merge branch 'master' into experience/7078/node-18
jpandersen87 Mar 7, 2023
ae6fa49
revert string changes due to 18.15
jpandersen87 Mar 9, 2023
45a448f
Merge branch 'experience/7078/node-18' of https://github.com/CDCgov/p…
jpandersen87 Mar 9, 2023
96b3527
Merge branch 'master' into experience/7078/node-18
jpandersen87 Mar 9, 2023
cdb828b
18.15
jpandersen87 Mar 9, 2023
d524da1
typo
jpandersen87 Mar 9, 2023
a192b20
Merge branch 'master' into experience/7078/node-18
snesm Mar 10, 2023
5bef3b2
use explicit loopback ip address for proxy
jpandersen87 Mar 10, 2023
99ed291
Merge branch 'experience/7078/node-18' of https://github.com/CDCgov/p…
jpandersen87 Mar 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/build-frontend/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ runs:
- name: Use Node.js ${{ matrix.node-version }} with yarn
uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c
with:
node-version: "16.19.1"
node-version: "18.15"
JosiahSiegel marked this conversation as resolved.
Show resolved Hide resolved

- run: yarn install
working-directory: frontend-react
Expand Down
2 changes: 1 addition & 1 deletion frontend-react/.nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16.19.1
18.15
6 changes: 3 additions & 3 deletions frontend-react/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ Use the directions here to install nvm: https://github.com/nvm-sh/nvm#install--u
Then:

```bash
nvm install 16.19.x # refer to nvmrc for exact current version
node -v # v16.19.x
npm -v # v8.x.x
nvm install 18.15.x # refer to nvmrc for exact current version
node -v # v18.15.x
npm -v # v9.5.x

npm install --global yarn
```
Expand Down
2 changes: 1 addition & 1 deletion frontend-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,6 @@
"workbox-webpack-plugin": "^6.5.4"
},
"engines": {
"node": "~16.19.1"
"node": "~18.15"
}
}
6 changes: 3 additions & 3 deletions prime-router/docs/getting-started/Using-an-apple-silicon-mac.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,9 @@ Use the directions here to install nvm: https://github.com/nvm-sh/nvm#install--u
Then:

```bash
nvm install 16.19.x # refer to nvmrc for exact current version
node -v # v16.19.x
npm -v # v8.x.x
nvm install 18.15x # refer to nvmrc for exact current version
node -v # v18.15x
npm -v # v9.5.x

npm install --global yarn
```
Expand Down