-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Must Destroy OperatorField Objects #1646
Conversation
ToDo: Track down all the CPU memory leaks, add GPU restores, language wrapers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General question is whether the extra check during the restore is worth the new API, or just force the users to call *Destroy
on the objects obtained from CeedOperatorFieldGet*
.
I'm not sure what bugs the extra CeedCheck(*vec == op_field->vec, ...)
would catch.
See later comment for the fluids code that drove me to the above question.
2361dc6
to
54e15cd
Compare
Ok, rebased to work off the branch with the lingering Operator memory fix. Impl for CPU ref is in, rest in progress |
4502c7f
to
02da2a3
Compare
CPU blocked and ref in, GPU non-gen next. (would need to rebase in another open PR to do gen) OCCA will be annoying so I'm saving it for last |
fc5c85c
to
b377dfe
Compare
6feaff7
to
5862f7b
Compare
Yeah, all the errors are in the form |
9fddab1
to
067190e
Compare
Huzzah, at long last. I think this is good to add now, and I can spin up the companion PR to MFEM. Mildly disruptive but not a huge deal as it just leaks if not fixed downstream |
a071b1c
to
28bb427
Compare
#1673 takes priority. Will rework this branch after that merges |
6a975c5
to
1968171
Compare
Rebased, manually tested CUDA, HIP. CI won't run on Noether yet due to the failing fluids tests |
I'll try and fix those when I get back from lunch and my next meeting (which have now combined into the same event). |
(the bin files just needed to be updated if you want to do it yourself). |
1968171
to
d844be7
Compare
700701c
to
dbb6954
Compare
dbb6954
to
6782e2f
Compare
@jrwrigh CI has been updated, so HONEE can be updated now |
Fixes #1639
What do we think @jrwrigh. You can see how this does get a bit invasive.
Ok, now the Vector/ElemRestriction/Basis retrieved from the OperatorField needs to be Destroyed per the corresponding interface.