Added Humble #705
Merged
Added Humble #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bulkowy
reviewed
Jan 15, 2024
bulkowy
previously approved these changes
Jan 16, 2024
bulkowy
approved these changes
Jan 16, 2024
|
@cyberamt : thank you for your contribution ❤️ |
|
Hi, really cool that you were able to improve the code and have memorized it. I would be happy if you could include the account as "cyberamt" in the contributers. I will try to write more merge requests with tools if I like. |
|
Hello, added you as a contributor, thanks again for the code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new scanning modul to artemis called humble.
humble is an open source HTTP-Header security scanner (repo)
I have strongly oriented myself to the implementation of dnsreaper. humble.py has the class Humble which is responsible for the call and additionally the function process_json_data which parses the output.
The parser tries to parse missing security headers so that artemis can display them as interesting findings. If necessary, the parser needs a little refinement so that depricated headers and the like are correctly recognized as "interesting".
This pull request was first made for the artemis-extra-module repo.
Please review the changes and let me know if there are any concerns or suggestions for improvement.