Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1901 - Add class name in rows to identfy tag in DOM #1917

Merged
merged 2 commits into from
Mar 18, 2023

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Mar 18, 2023

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Mar 18, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e9fbb6c) 91.58% compared to head (7549c58) 91.58%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1917   +/-   ##
=======================================
  Coverage   91.58%   91.58%           
=======================================
  Files         277      277           
  Lines        9062     9063    +1     
=======================================
+ Hits         8299     8300    +1     
  Misses        763      763           
Impacted Files Coverage Δ
....Portal.Client/Pages/Settings/DeviceTagsPage.razor 94.87% <100.00%> (+0.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kbeaugrand kbeaugrand temporarily deployed to E2E March 18, 2023 12:44 — with GitHub Actions Inactive
@kbeaugrand kbeaugrand marked this pull request as ready for review March 18, 2023 13:21
@kbeaugrand kbeaugrand requested a review from a team as a code owner March 18, 2023 13:21
@kbeaugrand kbeaugrand merged commit ee40e2f into main Mar 18, 2023
@kbeaugrand kbeaugrand deleted the fix/1901-identify-tag-row-in-table-dom branch March 18, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Add id for the tags
1 participant