Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1901 - Add class name in rows to identfy tag in DOM #1917

Merged
merged 2 commits into from
Mar 18, 2023
Merged

Fix #1901 - Add class name in rows to identfy tag in DOM #1917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e8cb18
Fix #1901 - Add class name in rows to identfy tag in DOM
kbeaugrand Mar 18, 2023
7549c58
Fix E2E test
kbeaugrand Mar 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/AzureIoTHub.Portal.Client/Pages/Settings/DeviceTagsPage.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

<MudGrid>
<MudItem xs="12">
<MudTable Items="@Tags" Loading="isProcessing" Dense=true Hover=true Bordered=true Striped=true>
<MudTable Items="@Tags" Loading="isProcessing" Dense=true Hover=true Bordered=true Striped=true RowClassFunc="@((DeviceTagModel m, int index) => $"tag-{m.Name}")">

<ToolBarContent>
<MudText Typo="Typo.h6">Tags</MudText>
Expand Down
16 changes: 14 additions & 2 deletions src/AzureIoTHub.Portal.Tests.E2E/Pages/EdgeModelPage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,22 @@ public void SearchEdgeModel(string description)
WebDriverFactory.Default.FindElement(By.Id("edge-model-search-keyword")).SendKeys(description);

_ = wait.Until(d => d.FindElement(By.Id("edge-model-search-button")).Displayed);
WebDriverFactory.Default.FindElement(By.Id("edge-model-search-button")).Click();
}

WebDriverFactory.Default.FindElement(By.Id("edge-model-search-button")).Click();

_ = wait.Until(d =>
{
try
{
_ = WebDriverFactory.Default.FindElement(By.ClassName("mud-table-loading"));
return false;
}
catch (NoSuchElementException)
{
return true;
}
});
}


public void RemoveEdgeModel(string name)
Expand Down