-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoiding conflicts in set_nml and set_env options #243
Comments
Add warning messages when multiple set options overlap (CICE-Consortium#243) Fix namelist output diagnostic for atmbndy (CICE-Consortium#493) Modify git clone in script to use --depth=1 (CICE-Consortium#492)
#494 adds some new script warning messages when --set introduces conflicts in namelist or env variables. It continues to process as always, but this should provide information that might allow us to avoid these conflicts in the future. |
…ut, script warning messages for --set conflicts (#494) * Add support for .cice_set (#464) Add warning messages when multiple set options overlap (#243) Fix namelist output diagnostic for atmbndy (#493) Modify git clone in script to use --depth=1 (#492) * update doc precedence * update documentation, add info about .cice_set format Co-authored-by: Philippe Blain <levraiphilippeblain@gmail.com>
It sounds like #494 addresses the issues here sufficiently. Are there still remaining issues that ought to be addressed, or can we close this one? |
It could certainly be improved or changed, but I think what we have is OK. I think we could close this. |
This was originally raised in #140.
There is also a question about how to handle the options (--sets). There is a question of precedent and some problems have arisen in usage. At this point, there are few constraints on what can be defined in the set_nml and set_env options. Users can mix and match multiple options and the changes will be implemented based on the option name alphabetically. This can create problems if conflicting settings are defined in different options files and a user chooses them. This probably needs to be fixed. There are a couple ways this could be fixed.
There may be other ways to address this issue as well.
The text was updated successfully, but these errors were encountered: