Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in log output for atmbndy. #493

Closed
dabail10 opened this issue Jul 20, 2020 · 5 comments
Closed

Bug in log output for atmbndy. #493

dabail10 opened this issue Jul 20, 2020 · 5 comments
Assignees
@apcraig
Labels
IO Type: Bug

Comments

@dabail10
Copy link
Contributor

I believe this logic is incorrect for atmbndy.

     if (trim(atmbndy) == 'constant') then
        tmpstr2 = ': stability-based boundary layer'
        write(nu_diag,1012) ' highfreq         = ', highfreq,' high-frequency atmospheric coupling'
        write(nu_diag,1022) ' natmiter         = ', natmiter,' number of atmo boundary layer iterations'
        write(nu_diag,1006) ' atmiter_conv     = ', atmiter_conv,' convergence criterion for ustar'
     elseif (trim(atmbndy) == 'default') then
        tmpstr2 = ': boundary layer uses bulk transfer coefficients'
     endif

That should be if atmbndy = 'default'.
@eclare108213
Copy link
Contributor

Ok. Maybe the next person who puts in a PR can fix this, or add it to a current one.

@dabail10
Copy link
Contributor Author

I could do this, but I don't have a CICE PR coming up.

@apcraig apcraig self-assigned this Jul 22, 2020
@apcraig
Copy link
Contributor

apcraig commented Jul 22, 2020

I'm fixing this in a PR now. Just to clarify, the if tests just need to be switched? The first if should be "default" and the second should be "constant"?

@dabail10
Copy link
Contributor Author

That's correct. Thanks Tony.

apcraig added a commit to apcraig/CICE that referenced this issue Jul 23, 2020
@apcraig
Add support for .cice_set (CICE-Consortium#464)
1c644df 
Add warning messages when multiple set options overlap (CICE-Consortium#243)
Fix namelist output diagnostic for atmbndy (CICE-Consortium#493)
Modify git clone in script to use --depth=1 (CICE-Consortium#492)
@apcraig apcraig mentioned this issue Jul 23, 2020
Merged
16 tasks
apcraig added a commit that referenced this issue Jul 31, 2020
@apcraig @phil-blain
Add support for .cice_set, git clone --depth=1, atmbndy namelist outp…
9e8a300 
…ut, script warning messages for --set conflicts (#494)

* Add support for .cice_set (#464)
Add warning messages when multiple set options overlap (#243)
Fix namelist output diagnostic for atmbndy (#493)
Modify git clone in script to use --depth=1 (#492)

* update doc precedence

* update documentation, add info about .cice_set format

Co-authored-by: Philippe Blain <levraiphilippeblain@gmail.com>
@apcraig
Copy link
Contributor

apcraig commented Jul 31, 2020

Fixed in #494

@apcraig apcraig closed this as completed Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apcraig apcraig

Labels
IO Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eclare108213 @apcraig @dabail10