Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alloc dyn4 #194

Merged
merged 10 commits into from
Sep 28, 2018
Merged

Alloc dyn4 #194

merged 10 commits into from
Sep 28, 2018

Conversation

mhrib
Copy link
Contributor

@mhrib mhrib commented Sep 27, 2018

Based on:
#183

CICE with dynamics allocatable through namelist

Developer(s): Mads Hvid Ribergaard, DMI

Please suggest code Pull Request reviewers in the column at right.
Tony?

Are the code changes bit for bit, different at roundoff level, or more substantial?
Yes: BIT for BIT identical

Is the documentation being updated with this PR? (Y/N): NO
If not, does the documentation need to be updated separately at a later time? (Y/N): ?
Note: "Documentation" includes information on the wiki and .rst files in doc/source/,
which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.

Other Relevant Details:

One of my test using GX3 (24 iterations):
CICE_v6/GX3> md5sum history./icednc
1b47affe3502c4e9354691c22785c916 history.AllocDyn/iced.1998-01-02-00000.nc
1b47affe3502c4e9354691c22785c916 history.master/iced.1998-01-02-00000.nc

--o--

INFO:

New namelist info (and default values):
&domain_nml
nprocs = -1
max_blocks = -1 ! MXBLCK
block_size_x = -1 ! BLCKX
block_size_y = -1 ! BLCKY
nx_global = -1 ! NXGLOB
ny_global = -1 ! NYGLOB
...

CICE stops with ERROR if the namelist settings are <1 - except for max_blocks. If max_blocks is <1 it is automatically calculated/estimated as:
max_blocks=( ((nx_global-1)/block_size_x + 1) * ((ny_global-1)/block_size_y + 1) ) / nprocs

--o--

affected files:
cicecore/shared/ice_domain_size.F90
cicecore/shared/ice_arrays_column.F90
cicecore/drivers/cice/CICE_InitMod.F90
cicecore/drivers/hadgem3/CICE_InitMod.F90
cicecore/drivers/cesm/CICE_InitMod.F90
cicecore/cicedynB/infrastructure/ice_grid.F90
cicecore/cicedynB/infrastructure/ice_restoring.F90
cicecore/cicedynB/general/ice_flux.F90
cicecore/cicedynB/general/ice_state.F90
cicecore/cicedynB/general/ice_forcing.F90
cicecore/cicedynB/general/ice_forcing_bgc.F90
cicecore/cicedynB/general/ice_flux_bgc.F90
configuration/scripts/ice_in (setup to GX3)

--o--

TIP: If you want to keep the CPPDEFS to specify blocks, grid size etc., You can add a "sed" command similar to this:

cat ice_in_tmp | sed s/'^.nprocs.$'/" nprocs = ${nprocs}"/g
| sed s/'^.max_blocks.$'/" , max_blocks = ${MXBLCK}"/g
| sed s/'^.block_size_x.$'/" , block_size_x = ${BLCKX}"/g
| sed s/'^.block_size_y.$'/" , block_size_y = ${BLCKY}"/g
| sed s/'^.nx_global.$'/" , nx_global = ${NXGLOB}"/g
| sed s/'^.ny_global.$'/" , ny_global = ${NYGLOB}"/g > ice_in

MXBLCK can be set to 0. The it is calculated as:
max_blocks = (nx_global/block_size_x)*(ny_global/block_size_y) / nprocs
(as suggested within ice_domain_size.F90)

mhrib and others added 10 commits September 13, 2018 13:51
* update pgi compiler optimization to address reproducibility problems

* Dummy and unused variables. (CICE-Consortium#180)

* Remove some dummy arguments and unused variables.

* Dummy variable cleanup

* Cleanup

* Remove icepack from commit

* Reset icepack master

* Fix

* Fix

* Update icepack

* fix

* Fix flush ifdef logic

* Uninitialized variables.

* Additional initialization

* Update dummy

* more dummy fixes

* More hobart changes

* Update Hobart Intel settings

* Additional Hobart Intel changes

* Update icepack

* Some tweaks to dummy variables

* Remove some initialization code.

* Only remove istat checks in one routine.

* update icepack (CICE-Consortium#188)
Copy link
Contributor

@apcraig apcraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apcraig apcraig merged commit 8492af9 into CICE-Consortium:master Sep 28, 2018
@apcraig apcraig mentioned this pull request Sep 28, 2018
@apcraig apcraig mentioned this pull request Oct 5, 2018
@mhrib mhrib deleted the AllocDyn4 branch November 8, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants