fix uarea initialization related to NYGLOB cpp #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhrib
added a commit
that referenced
this pull request
Oct 12, 2018
* Allocatable dynamics version using namelist * Updated ice_in according to "Allocated Dynamics" * update scripts to automatically set namelist associated with grids and blocks * fix uarea initialization related to NYGLOB cpp (#1) * update pgi optimzation to address reproducibility problems (#2) * mods for nag compiler failure (#3) * Update to Consortium master bbec5d1 (#4) * update pgi compiler optimization to address reproducibility problems * Dummy and unused variables. (CICE-Consortium#180) * Remove some dummy arguments and unused variables. * Dummy variable cleanup * Cleanup * Remove icepack from commit * Reset icepack master * Fix * Fix * Update icepack * fix * Fix flush ifdef logic * Uninitialized variables. * Additional initialization * Update dummy * more dummy fixes * More hobart changes * Update Hobart Intel settings * Additional Hobart Intel changes * Update icepack * Some tweaks to dummy variables * Remove some initialization code. * Only remove istat checks in one routine. * update icepack (CICE-Consortium#188) * fix ice_abort error in ice_state.F90 (#5)
mhrib
pushed a commit
that referenced
this pull request
Dec 10, 2019
* modifying PR template * updating PR template * adding link to documentation for PR (#1) * modifying PR template * typo * modifying wording * modifying link per PBsuggestion * adding second link * adding Tony's changes * typo * Making ECH suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the uarea calculation at ny_global which was implemented with a cpp depending on NYGLOB (which no longer exists). This is line 1508 in ice_grid.F90. The other changes are just indentation in that same area and a couple other minor fixes.
This fixes some of the problems, see
https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks
hash 465cd86. But pgi is still not behaving well and I will look into that next.