-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codecleanup3 #111
Codecleanup3 #111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excellent, thank you!
@duvivier One of the changes with this PR was complete removal of the module columnphysics/icepack_constants.F90. Reference to it also needs to be removed from the documentation, if it appears anywhere. Its contents were moved into columnphysics/icepack_parameters.F90. Thx! |
Travis-CI testing
Combine icepack_constants with icepack_parameters
Developer(s): E Hunke
Are the code changes bit for bit, different at roundoff level, or more substantial? BFB
Is the documentation being updated with this PR? (Y/N) not yet
If not, does the documentation need to be updated separately? (Y/N) Y
"Documentation" includes information on the wiki and .rst files in doc/source/,
which are used to create the online technical docs at https://cice-consortium.github.io/Icepack/
Please suggest code reviewers in the column at right.
Other Relevant Details:
This is not ready yet, just creating a PR so you know it's underway. Looks like I'll need to rebase after the previous PR is merged?