Doc compilation #139
Merged
Doc compilation #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apcraig
approved these changes
Feb 7, 2018
eclare108213
approved these changes
Feb 8, 2018
|
This commit broke the code. Removing radius in icedrv_constants.F90 was not done properly (the prior line has a continuation line associated with it and things are choking on that. I will fix this and push it now. |
|
sorry... thanks for noticing and fixing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of small documentation updates (see below for details)
Developer(s): Alice DuVivier
Are the code changes bit for bit, different at roundoff level, or more substantial? bit for bit
Is the documentation being updated with this PR? Y
If not, does the documentation need to be updated separately? N/A
"Documentation" includes information on the wiki and .rst files in doc/source/,
which are used to create the online technical docs at https://cice-consortium.github.io/Icepack/
Please suggest code reviewers in the column at right.
Other Relevant Details:
Takes care of the following outstanding tasks:
Issue #73 : BGC forcing description in doc/source/user_guide/ug_case_settings.rst and doc/source/user_guide/ug_running.rst . Will require a bit more info from @njeffery
Issue #79 : Forcing described in doc/source/user_guide/ug_running.rst . Will require update to SHEBA from @dabail10
PR #106 : Addressed removal of items @dabail10 and @eclare108213 mentioned in comments. See doc/source/icepack_index.rst and configuration/driver/icedrv_constants.F90
Issue #110 and PR #111 : Removed references to icepack_constants.F90 doc/source/developer_guide/dg_col_phys.rst
PR #115 : Added that updates will be part of release documentation doc/source/intro/major_updates.rst