forked from argilla-io/argilla
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
…3567) # Description When using PostgreSQL, the changes made after a `begin_nested` where not being written to the database because missing `commit`. This didn't happen when using SQLite3, which was writing the data even without executing a `commit`. **Type of change** - [x] Bug fix (non-breaking change which fixes an issue) **How Has This Been Tested** I've tested in a local development environment with PostgreSQL all the endpoints that were using `begin_nested`: - [x] Publish dataset - [x] Delete dataset - [x] Delete record - [x] Create records - [x] Create response - [x] Update response - [x] Delete response **Checklist** - [x] I followed the style guidelines of this project - [x] I did a self-review of my code - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK) (see text above) - [x] I have added relevant notes to the `CHANGELOG.md` file (See https://keepachangelog.com/)
- Loading branch information
1 parent
3f926b4
commit 832271b
Showing
3 changed files
with
25 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters