fix: add missing database commits after begin_nested
#3567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielmbmb
added
type: bug
gabrielmbmb
changed the title
commits after begin_nested
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## releases/1.14.1 #3567 +/- ##
===================================================
+ Coverage 90.41% 90.49% +0.07%
===================================================
Files 255 255
Lines 13535 13543 +8
===================================================
+ Hits 12238 12256 +18
+ Misses 1297 1287 -10
☔ View full report in Codecov by Sentry. |
artikandri
pushed a commit
to CLARIN-PL/argilla
that referenced
this pull request
Oct 30, 2023
…3567) # Description When using PostgreSQL, the changes made after a `begin_nested` where not being written to the database because missing `commit`. This didn't happen when using SQLite3, which was writing the data even without executing a `commit`. **Type of change** - [x] Bug fix (non-breaking change which fixes an issue) **How Has This Been Tested** I've tested in a local development environment with PostgreSQL all the endpoints that were using `begin_nested`: - [x] Publish dataset - [x] Delete dataset - [x] Delete record - [x] Create records - [x] Create response - [x] Update response - [x] Delete response **Checklist** - [x] I followed the style guidelines of this project - [x] I did a self-review of my code - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK) (see text above) - [x] I have added relevant notes to the `CHANGELOG.md` file (See https://keepachangelog.com/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using PostgreSQL, the changes made after a
begin_nestedwhere not being written to the database because missingcommit. This didn't happen when using SQLite3, which was writing the data even without executing acommit.Type of change
How Has This Been Tested
I've tested in a local development environment with PostgreSQL all the endpoints that were using
begin_nested:Checklist
CHANGELOG.mdfile (See https://keepachangelog.com/)