Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove codecov from ci #933

Merged
merged 2 commits into from
Apr 24, 2024
+0 −8
Merged

remove codecov from ci #933

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16f7360
remove codecov from ci
laurenkrugen-navapbc Apr 24, 2024
2d1a3a1
add back in the codecov archival
laurenkrugen-navapbc Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions .github/workflows/ci-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,19 +49,6 @@ jobs:
- name: Run all tests
run: |
make test
- name: Generate codecov report
uses: codecov/codecov-action@v2
with:
files: ./test_results/latest/testcoverage.out # optional
flags: unittests # optional
name: codecov-umbrella # optional
fail_ci_if_error: true # optional (default = false)
verbose: true # optional (default = false)
- name: Archive code coverage results
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can stay

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking of removing this portion instead? https://github.com/CMSgov/bcda-app/pull/933/files#diff-e42b2b9794d0333e41c8e218ece5897ea7395746b5e07d08fb85b53e36d15043L71-L74

If we remove the codecov report generation but keep in the artifact, would it fail when it searches the path for the testcoverage.out?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I'm thinking; it's going to look for code-coverage-report and then fail

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go has built-in test coverage tools, so the file still gets generated, from what I can tell.

uses: actions/upload-artifact@v2
with:
name: code-coverage-report
path: ./test_results/latest/testcoverage.out
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thru here


sonar-quality-gate:
name: Sonarqube Quality Gate
Expand Down
Loading