Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix land mask around antarctic regions #1

Merged
merged 3 commits into from
Sep 15, 2022
Merged

Fix land mask around antarctic regions #1

merged 3 commits into from
Sep 15, 2022

Conversation

micaeljtoliveira
Copy link
Contributor

@micaeljtoliveira micaeljtoliveira commented Sep 7, 2022 •
edited
Loading

@micaeljtoliveira micaeljtoliveira marked this pull request as draft September 7, 2022 06:06
@micaeljtoliveira
Copy link
Contributor Author

@aekiss I'm still missing one hand-edit to the land mask to fix one non-advective cell, but otherwise this should be ready to be reviewed.

@aekiss
Copy link
Contributor

aekiss commented Sep 7, 2022

it looks flawless so far

@micaeljtoliveira micaeljtoliveira marked this pull request as ready for review September 15, 2022 05:48
aekiss
aekiss approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@aekiss aekiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks - looks good to me

@aekiss aekiss merged commit 4ae7378 into master Sep 15, 2022
@micaeljtoliveira micaeljtoliveira deleted the fix_antarctic_land_mask branch July 19, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aekiss aekiss aekiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix land mask around Antarctic coast for 0.25deg topography
2 participants
@micaeljtoliveira @aekiss