Add two new tools and extend another #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will be needed to fix COSIMA/access-om2#265 |
|
@aekiss Would you mind reviewing this when you have some time? Thanks! |
aekiss
reviewed
Sep 7, 2022
aekiss
reviewed
Sep 7, 2022
aekiss
reviewed
Sep 7, 2022
aekiss
requested changes
Sep 7, 2022
There was a problem hiding this comment.
thanks @micaeljtoliveira this looks great - just a few small comments
…in a mask file; the other combines two masks. Also modified the topog2mask.py utility to take treat cells with a fraction of ocean lower than a user-provided value as land.
micaeljtoliveira
force-pushed
the
add_more_tools
branch
from
6614403
to
03cfc66
Compare
|
@aekiss Thanks for the careful review! I've addressed all your comments. |
|
thanks @micaeljtoliveira |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two new tools: one automatically fixes non-advective cells found in a mask file; the other combines two masks. Also modified the topog2mask.py utility to take treat cells with a fraction of ocean lower than a user-provided value as land.