Add announce integration #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 4, 2019 15:44
Receive is probably a bit incorrect, depending on how Ross decides to send the json
SailSlick
reviewed
Mar 5, 2019
| @@ -451,3 +451,68 @@ func (s *serverWrapper) handleApprovalActivity() http.HandlerFunc { | |||
| fmt.Fprintf(w, "{}\n") | |||
| } | |||
| } | |||
|
|
|||
| // TODO(sailslick): Properly fill in announce structs | |||
There was a problem hiding this comment.
Could you get this off the send announce service?
skinny/ap.go
Outdated
| } | ||
|
|
||
| f := &pb.ReceivedAnnounceDetails{ | ||
| AnnouncedObject: t.Object, |
There was a problem hiding this comment.
There are some more fields to this part that aren't in master. I'll publish a wip pr with them
SailSlick
approved these changes
Mar 5, 2019
This is a partial merge from PR 413
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #386
To some degree I'm waiting on @SailSlick's format for sending before it can be properly parsed, but I've put a TODO there instead.