Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Receive announce activity #413

Merged
merged 7 commits into from
Mar 9, 2019
Merged

Receive announce activity #413

merged 7 commits into from
Mar 9, 2019

Conversation

SailSlick
Copy link
Contributor

@SailSlick SailSlick commented Mar 5, 2019 •
edited
Loading

closes #379

  • Add receive activity ability
  • Add a util for the announce service

Warning

  • The db calls used in this service have not been added yet

@SailSlick SailSlick mentioned this pull request Mar 5, 2019
Merged
@SailSlick SailSlick force-pushed the r/receive-announce branch from 1a27349 to e0c00fd Compare March 7, 2019 11:50
@SailSlick
Copy link
Contributor Author

force push to rebase

@SailSlick SailSlick changed the title (WIP) receive announce activity Receive announce activity Mar 7, 2019
@SailSlick SailSlick force-pushed the r/receive-announce branch from e0c00fd to 7f29215 Compare March 7, 2019 16:02
@SailSlick
Copy link
Contributor Author

force push to rebase

devoxel
devoxel approved these changes Mar 9, 2019
View reviewed changes
Copy link

@devoxel devoxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few comments

services/activities/announce/receive_announce_servicer.py
return article

def add_share_update_count(self, announcer, article, announce_time):
'''
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add TODO here

@SailSlick SailSlick merged commit 253eb8b into master Mar 9, 2019
@SailSlick SailSlick deleted the r/receive-announce branch March 9, 2019 15:50
@SailSlick SailSlick mentioned this pull request Mar 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devoxel devoxel devoxel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Receive announce activity
2 participants
@SailSlick @devoxel