Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add get_extern_func #28

Merged
merged 2 commits into from
Jun 18, 2024
Merged

feat: add get_extern_func #28

merged 2 commits into from
Jun 18, 2024

Conversation

doug-q
Copy link
Collaborator

@doug-q doug-q commented Jun 14, 2024

No description provided.

@doug-q doug-q requested a review from peter-campora June 14, 2024 14:17
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 90.74074% with 5 lines in your changes missing coverage. Please review.

Project coverage is 83.84%. Comparing base (4ae1b8a) to head (596983e).

Files Patch % Lines
src/emit.rs 86.20% 2 Missing and 2 partials ⚠️
src/emit/func.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   83.21%   83.84%   +0.63%     
==========================================
  Files          11       11              
  Lines        1513     1554      +41     
  Branches     1513     1554      +41     
==========================================
+ Hits         1259     1303      +44     
+ Misses        168      165       -3     
  Partials       86       86              
Flag Coverage Δ
rust 83.84% <90.74%> (+0.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@peter-campora peter-campora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This will be useful for defining or getting the inkwell function bindings while traversing nodes in HUGR.

@peter-campora peter-campora mentioned this pull request Jun 17, 2024
@doug-q doug-q added this pull request to the merge queue Jun 18, 2024
Merged via the queue into main with commit 2f64087 Jun 18, 2024
10 checks passed
@doug-q doug-q deleted the doug/extern-funcs branch June 18, 2024 06:19
@hugrbot hugrbot mentioned this pull request Jun 26, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jul 10, 2024
## 🤖 New release
* `hugr-llvm`: 0.1.0

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

## [0.1.0](https://github.com/CQCL/hugr-llvm/releases/tag/v0.1.0) -
2024-07-10

### Bug Fixes
- Syntax error
- sum type tag elision logic reversed
- [**breaking**] Allow Const and FuncDecl as children of Modules,
Dataflow Parents, and CFG nodes
([#46](#46))

### Documentation
- fix bad grammar ([#34](#34))

### New Features
- Emission for Call nodes
- Support  values
- add `get_extern_func`
([#28](#28))
- lower CFGs ([#26](#26))
- Add initial codegen extension for `prelude`
([#29](#29))
- [**breaking**] `Namer` optionally appends node index to mangled names.
([#32](#32))
- Implement lowerings for ieq,ilt_s,sub in int codegen extension
([#33](#33))
- Add initial `float` extension
([#31](#31))
- Emit more int comparison operators
([#47](#47))

### Refactor
- clean up fat.rs ([#38](#38))

### Testing
- add a test for sum type tags
- Add integration tests lowering guppy programs
([#35](#35))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

---------

Co-authored-by: Douglas Wilson <douglas.wilson@quantinuum.com>
@hugrbot hugrbot mentioned this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants