feat!: Namer optionally appends node index to mangled names.
#32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doug-q
force-pushed
the
doug/refactor-namer-args
branch
from
b5fc455 to
58c84a1
Compare
doug-q
changed the title
Namer optionally appends node index to mangled names.
We take this opportunity to move some auxilliary code out of emit.rs, and to fix up some docs in fat.rs
doug-q
force-pushed
the
doug/refactor-namer-args
branch
from
58c84a1 to
a8e2e9b
Compare
cqc-alec
approved these changes
Jun 18, 2024
src/fat.rs
Outdated
| /// Panics if the node is not valid in the `Hugr` or if it's `get_optype` is | ||
| /// not an `OT`. | ||
| /// | ||
| /// Note that while we do check that the type of the node's `get_optype`, we do |
There was a problem hiding this comment.
This sentence seems incomplete; something missing after "while we do check that the type of the node's get_optype".
There was a problem hiding this comment.
I think it is complete, continued on the following line.
"Note that while we do check that the type of the node's get_optype, we do not verify that it is actually equal to ot.:
There was a problem hiding this comment.
I think it is complete, continued on the following line.
"Note that while we do check that the type of the node's
get_optype, we do not verify that it is actually equal toot.:
This isn't grammatical -- perhaps you want to delete the second "that"?
Co-authored-by: Alec Edgington <54802828+cqc-alec@users.noreply.github.com>
Co-authored-by: Alec Edgington <54802828+cqc-alec@users.noreply.github.com>
Co-authored-by: Alec Edgington <54802828+cqc-alec@users.noreply.github.com>
Co-authored-by: Alec Edgington <54802828+cqc-alec@users.noreply.github.com>
Co-authored-by: Alec Edgington <54802828+cqc-alec@users.noreply.github.com>
Co-authored-by: Alec Edgington <54802828+cqc-alec@users.noreply.github.com>
Co-authored-by: Alec Edgington <54802828+cqc-alec@users.noreply.github.com>
…g/refactor-namer-args
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
## 🤖 New release * `hugr-llvm`: 0.1.0 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.1.0](https://github.com/CQCL/hugr-llvm/releases/tag/v0.1.0) - 2024-07-10 ### Bug Fixes - Syntax error - sum type tag elision logic reversed - [**breaking**] Allow Const and FuncDecl as children of Modules, Dataflow Parents, and CFG nodes ([#46](#46)) ### Documentation - fix bad grammar ([#34](#34)) ### New Features - Emission for Call nodes - Support values - add `get_extern_func` ([#28](#28)) - lower CFGs ([#26](#26)) - Add initial codegen extension for `prelude` ([#29](#29)) - [**breaking**] `Namer` optionally appends node index to mangled names. ([#32](#32)) - Implement lowerings for ieq,ilt_s,sub in int codegen extension ([#33](#33)) - Add initial `float` extension ([#31](#31)) - Emit more int comparison operators ([#47](#47)) ### Refactor - clean up fat.rs ([#38](#38)) ### Testing - add a test for sum type tags - Add integration tests lowering guppy programs ([#35](#35)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). --------- Co-authored-by: Douglas Wilson <douglas.wilson@quantinuum.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We take this opportunity to move some auxilliary code out of emit.rs,
and to fix up some docs in fat.rs.
BREAKING CHANGE:
Namer::newtakes an additional parameter.