Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call cannot have order edges #1284

Closed
doug-q opened this issue Jul 9, 2024 · 2 comments · Fixed by #1293
Closed

Call cannot have order edges #1284

doug-q opened this issue Jul 9, 2024 · 2 comments · Fixed by #1293
Labels
bug Something isn't working

Comments

@doug-q
Copy link
Collaborator

doug-q commented Jul 9, 2024

As #1167. This is a significantly more urgent problem.
@doug-q doug-q added the bug Something isn't working label Jul 9, 2024
@doug-q
Copy link
Collaborator Author

doug-q commented Jul 9, 2024

Maybe I am wrong here, we have static_input and other_input, it seems both LoadConstant and Call have order edges in other_input. Sorry for the noise if this is my misunderstanding.

@doug-q doug-q mentioned this issue Jul 11, 2024
Merged
@ss2165
Copy link
Member

ss2165 commented Jul 12, 2024

Not an issue, demonstrated in #1293

@ss2165 ss2165 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 12, 2024
github-merge-queue bot pushed a commit that referenced this issue Jul 16, 2024
@doug-q
test: verify order edges (#1293)
a6a9b74 
fixes #1167 fixes #1284
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: verify order edges CQCL/hugr
2 participants
@ss2165 @doug-q