Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve_opaque_op fails when OpaqueOp does not explicitly require it's own extension. #1315

Closed
doug-q opened this issue Jul 16, 2024 · 1 comment · Fixed by #1317
Closed

resolve_opaque_op fails when OpaqueOp does not explicitly require it's own extension. #1315

doug-q opened this issue Jul 16, 2024 · 1 comment · Fixed by #1317
Assignees
@doug-q

Comments

@doug-q
Copy link
Collaborator

doug-q commented Jul 16, 2024

Perhaps OpaqueOps extension should get added to it's signature before the comparison?
@acl-cqc
Copy link
Contributor

acl-cqc commented Jul 16, 2024

See also #1209. However your suggestion is a less "dangerous" sounding fix for any regression caused by #1226 and if resolve_opaque_op isn't causing trouble with other extension mismatches then it might well make sense to do that. (IOW it's a "backwards compatibility fix" for Hugrs serialized before #1226)

doug-q added a commit that referenced this issue Jul 16, 2024
@doug-q
test: Add failing test case for #1315
4f3cda8
@doug-q doug-q linked a pull request Jul 16, 2024 that will close this issue
fix: add op's extension to signature check in resolve_opaque_op #1317
Merged
@doug-q doug-q self-assigned this Jul 16, 2024
github-merge-queue bot pushed a commit that referenced this issue Jul 16, 2024
@doug-q @cqc-alec
test: Add failing test case for #1315 (#1316)
6f8dac2 
Co-authored-by: Alec Edgington <54802828+cqc-alec@users.noreply.github.com>
@hugrbot hugrbot mentioned this issue Jul 16, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 19, 2024
@hugrbot @doug-q
chore: release (#1314)
ed5876c 
## 🤖 New release
* `hugr`: 0.8.0 -> 0.9.0
* `hugr-core`: 0.5.0 -> 0.6.0
* `hugr-passes`: 0.5.0 -> 0.6.0
* `hugr-cli`: 0.1.4 -> 0.2.0

<details><summary><i><b>Changelog</b></i></summary><p>

## `hugr`
<blockquote>

## 0.9.0 (2024-07-19)

### Bug Fixes

- Add op's extension to signature check in `resolve_opaque_op`
([#1317](#1317))
- Panic on `SimpleReplace` with multiports
([#1324](#1324))

### Refactor

- [**breaking**] Separate Signature from FuncValueType by parametrizing
Type(/Row)/etc. ([#1138](#1138))

### Testing

- Verify order edges ([#1293](#1293))
- Add failing test case for
[#1315](#1315)
([#1316](#1316))
</blockquote>

## `hugr-core`
<blockquote>

## 0.6.0 (2024-07-19)

### Bug Fixes

- Add op's extension to signature check in `resolve_opaque_op`
([#1317](#1317))
- Panic on `SimpleReplace` with multiports
([#1324](#1324))

### Refactor

- [**breaking**] Separate Signature from FuncValueType by parametrizing
Type(/Row)/etc. ([#1138](#1138))

### Testing

- Verify order edges ([#1293](#1293))
- Add failing test case for
[#1315](#1315)
([#1316](#1316))
</blockquote>

## `hugr-passes`
<blockquote>

## 0.6.0 (2024-07-19)

### Refactor

- [**breaking**] Separate Signature from FuncValueType by parametrizing
Type(/Row)/etc. ([#1138](#1138))
</blockquote>

## `hugr-cli`
<blockquote>

## 0.2.0 (2024-07-19)

### Refactor

- [**breaking**] Separate Signature from FuncValueType by parametrizing
Type(/Row)/etc. ([#1138](#1138))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

---------

Co-authored-by: Douglas Wilson <douglas.wilson@quantinuum.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@doug-q doug-q

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add op's extension to signature check in resolve_opaque_op CQCL/hugr
2 participants
@acl-cqc @doug-q