fix: IndexError on node slicing #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1500 +/- ##
=======================================
Coverage 87.29% 87.29%
=======================================
Files 126 126
Lines 21633 21633
Branches 18662 18662
=======================================
Hits 18884 18884
Misses 1979 1979
Partials 770 770
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
croyzor
approved these changes
Sep 3, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
🤖 I have created a release *beep* *boop* --- ## [0.8.1](hugr-py-v0.8.0...hugr-py-v0.8.1) (2024-09-04) ### Features * Export the collections extension ([#1506](#1506)) ([70e0a64](70e0a64)) ### Bug Fixes * Export the float ops extension ([#1517](#1517)) ([4cbe890](4cbe890)) * IndexError on node slicing ([#1500](#1500)) ([a32bd84](a32bd84)) * Update collections extension ([#1518](#1518)) ([60e1da0](60e1da0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1498
Python lets you slice out of range;
[0,1][90:99]returns an empty list. This PR makes node slicing behave as such.