Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Export the collections extension #1506

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Conversation

aborgna-q
Copy link
Collaborator

#1450 embedded the standard extension definitions in hugr-py, including collections, but it didn't add a way to load it as it did with all the others.

This PR adds a hugr.std.collections module that just loads the bundled json.

drive-by: Implement __str__ for FloatVal and IntVal

@aborgna-q aborgna-q requested a review from a team as a code owner September 3, 2024 10:34
@aborgna-q aborgna-q requested a review from zrho September 3, 2024 10:34
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 64.28571% with 10 lines in your changes missing coverage. Please review.

Project coverage is 87.26%. Comparing base (be9e2be) to head (8de7750).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
hugr-py/src/hugr/std/collections.py 65.21% 8 Missing ⚠️
hugr-py/src/hugr/std/float.py 50.00% 1 Missing ⚠️
hugr-py/src/hugr/std/int.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1506      +/-   ##
==========================================
- Coverage   87.29%   87.26%   -0.03%     
==========================================
  Files         126      127       +1     
  Lines       21633    21661      +28     
  Branches    18662    18662              
==========================================
+ Hits        18884    18902      +18     
- Misses       1979     1989      +10     
  Partials      770      770              
Flag Coverage Δ
python 92.46% <64.28%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aborgna-q aborgna-q requested review from croyzor and removed request for zrho September 3, 2024 14:12
@aborgna-q aborgna-q added this pull request to the merge queue Sep 3, 2024
Merged via the queue into main with commit 70e0a64 Sep 3, 2024
19 of 20 checks passed
@aborgna-q aborgna-q deleted the ab/export-collections branch September 3, 2024 14:20
github-merge-queue bot pushed a commit that referenced this pull request Sep 4, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.8.1](hugr-py-v0.8.0...hugr-py-v0.8.1)
(2024-09-04)


### Features

* Export the collections extension
([#1506](#1506))
([70e0a64](70e0a64))


### Bug Fixes

* Export the float ops extension
([#1517](#1517))
([4cbe890](4cbe890))
* IndexError on node slicing
([#1500](#1500))
([a32bd84](a32bd84))
* Update collections extension
([#1518](#1518))
([60e1da0](60e1da0))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants