feat(hugr-cli)!: allow registry specification in run_dump
#1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ss2165
commented
Sep 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1501 +/- ##
=======================================
Coverage 87.29% 87.29%
=======================================
Files 126 126
Lines 21633 21633
Branches 18662 18662
=======================================
Hits 18884 18884
Misses 1979 1979
Partials 770 770
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
aborgna-q
approved these changes
Sep 3, 2024
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
## 🤖 New release * `hugr`: 0.12.0 -> 0.12.1 * `hugr-core`: 0.9.0 -> 0.9.1 * `hugr-passes`: 0.8.0 -> 0.8.1 * `hugr-cli`: 0.5.0 -> 0.6.0 <details><summary><i><b>Changelog</b></i></summary><p> ## `hugr` <blockquote> ## 0.12.1 (2024-09-04) ### Bug Fixes - `std.collections.insert` wrong output order ([#1513](#1513)) ### Features - Op replacement and lowering functions ([#1509](#1509)) </blockquote> ## `hugr-core` <blockquote> ## 0.9.1 (2024-09-04) ### Bug Fixes - `std.collections.insert` wrong output order ([#1513](#1513)) </blockquote> ## `hugr-passes` <blockquote> ## 0.8.1 (2024-09-04) ### Features - Op replacement and lowering functions ([#1509](#1509)) </blockquote> ## `hugr-cli` <blockquote> ## 0.6.0 (2024-09-04) ### Features - [**breaking**] Allow registry specification in `run_dump` ([#1501](#1501)) - [**breaking**] Add `Package::validate` and return `ExtensionRegistry` in helpers. ([#1507](#1507)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/).
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 8, 2024
## 🤖 New release * `hugr`: 0.12.1 -> 0.13.0 (✓ API compatible changes) * `hugr-core`: 0.9.1 -> 0.10.0 (✓ API compatible changes) * `hugr-passes`: 0.8.1 -> 0.8.2 (✓ API compatible changes) * `hugr-cli`: 0.6.0 -> 0.6.1 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> ## `hugr` <blockquote> ## 0.13.0 (2024-10-08) ### Bug Fixes - [**breaking**] Make list length op give back the list ([#1547](#1547)) ### Features - [**breaking**] Allow CustomConsts to (optionally) be hashable ([#1397](#1397)) - Add an `OpLoadError` variant of `BuildError`. ([#1537](#1537)) - [**breaking**] `HugrMut::remove_node` and `SimpleReplacement` return removed weights ([#1516](#1516)) - Draft for `hugr-model` with export, import, parsing and pretty printing ([#1542](#1542)) </blockquote> ## `hugr-core` <blockquote> ## 0.10.0 (2024-10-08) ### Bug Fixes - [**breaking**] Make list length op give back the list ([#1547](#1547)) ### Features - [**breaking**] Allow CustomConsts to (optionally) be hashable ([#1397](#1397)) - Add an `OpLoadError` variant of `BuildError`. ([#1537](#1537)) - [**breaking**] `HugrMut::remove_node` and `SimpleReplacement` return removed weights ([#1516](#1516)) - Draft for `hugr-model` with export, import, parsing and pretty printing ([#1542](#1542)) </blockquote> ## `hugr-passes` <blockquote> ## 0.8.1 (2024-09-04) ### Features - Op replacement and lowering functions ([#1509](#1509)) </blockquote> ## `hugr-cli` <blockquote> ## 0.6.0 (2024-09-04) ### Features - [**breaking**] Allow registry specification in `run_dump` ([#1501](#1501)) - [**breaking**] Add `Package::validate` and return `ExtensionRegistry` in helpers. ([#1507](#1507)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/).
Closed
This was referenced Oct 9, 2024
Closed
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 14, 2024
## 🤖 New release * `hugr`: 0.13.0 -> 0.13.1 (✓ API compatible changes) * `hugr-core`: 0.10.0 -> 0.13.1 (✓ API compatible changes) * `hugr-model`: 0.1.0 -> 0.13.1 (✓ API compatible changes) * `hugr-passes`: 0.8.2 -> 0.13.1 (✓ API compatible changes) * `hugr-cli`: 0.6.1 -> 0.13.1 <details><summary><i><b>Changelog</b></i></summary><p> ## `hugr` <blockquote> ## [0.13.1](hugr-v0.13.0...hugr-v0.13.1) - 2024-10-14 ### New Features - return replaced ops from lowering ([#1568](#1568)) - Make `BuildHandle::num_value_outputs` public ([#1560](#1560)) - `FunctionBuilder::add_{in,out}put` ([#1570](#1570)) - Binary serialisation format for hugr-model based on capnproto. ([#1557](#1557)) </blockquote> ## `hugr-core` <blockquote> ## [0.13.1](hugr-core-v0.10.0...hugr-core-v0.13.1) - 2024-10-14 ### New Features - Make `BuildHandle::num_value_outputs` public ([#1560](#1560)) - Binary serialisation format for hugr-model based on capnproto. ([#1557](#1557)) - `FunctionBuilder::add_{in,out}put` ([#1570](#1570)) </blockquote> ## `hugr-model` <blockquote> ## [0.13.1](hugr-model-v0.1.0...hugr-model-v0.13.1) - 2024-10-14 ### New Features - Binary serialisation format for hugr-model based on capnproto. ([#1557](#1557)) </blockquote> ## `hugr-passes` <blockquote> ## [0.13.1](hugr-passes-v0.8.2...hugr-passes-v0.13.1) - 2024-10-14 ### New Features - return replaced ops from lowering ([#1568](#1568)) </blockquote> ## `hugr-cli` <blockquote> ## 0.6.0 (2024-09-04) ### Features - [**breaking**] Allow registry specification in `run_dump` ([#1501](#1501)) - [**breaking**] Add `Package::validate` and return `ExtensionRegistry` in helpers. ([#1507](#1507)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). --------- Co-authored-by: Agustín Borgna <agustin.borgna@quantinuum.com> Co-authored-by: Agustín Borgna <121866228+aborgna-q@users.noreply.github.com> Co-authored-by: Alec Edgington <54802828+cqc-alec@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow downstream cli tools to dump their own extensions.
BREAKING CHANGE:
ExtArgs::run_dumpnow takes the registry to dump as an argument.