feat(hugr-passes): op replacement and lowering functions #1509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1509 +/- ##
==========================================
+ Coverage 87.26% 87.27% +0.01%
==========================================
Files 127 128 +1
Lines 21661 21717 +56
Branches 18662 18718 +56
==========================================
+ Hits 18902 18954 +52
- Misses 1989 1990 +1
- Partials 770 773 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
doug-q
reviewed
Sep 3, 2024
| replacements | ||
| .into_iter() | ||
| .map(|(node, replacement)| { | ||
| let subcirc = SiblingSubgraph::try_from_nodes([node], hugr)?; |
There was a problem hiding this comment.
This is a common pattern, it would be nice to write
Suggested change
| let subcirc = SiblingSubgraph::try_from_nodes([node], hugr)?; | |
| let subcirc = SiblingSubgraph::from_node(node, hugr); |
Do feel free to punt on this one.
doug-q
approved these changes
Sep 3, 2024
Offer simple interfaces for bulk lowering operations. `replace_ops` provided on top of lowering as replacing individual ops is much more efficient than splicing in subgraphs.
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
## 🤖 New release * `hugr`: 0.12.0 -> 0.12.1 * `hugr-core`: 0.9.0 -> 0.9.1 * `hugr-passes`: 0.8.0 -> 0.8.1 * `hugr-cli`: 0.5.0 -> 0.6.0 <details><summary><i><b>Changelog</b></i></summary><p> ## `hugr` <blockquote> ## 0.12.1 (2024-09-04) ### Bug Fixes - `std.collections.insert` wrong output order ([#1513](#1513)) ### Features - Op replacement and lowering functions ([#1509](#1509)) </blockquote> ## `hugr-core` <blockquote> ## 0.9.1 (2024-09-04) ### Bug Fixes - `std.collections.insert` wrong output order ([#1513](#1513)) </blockquote> ## `hugr-passes` <blockquote> ## 0.8.1 (2024-09-04) ### Features - Op replacement and lowering functions ([#1509](#1509)) </blockquote> ## `hugr-cli` <blockquote> ## 0.6.0 (2024-09-04) ### Features - [**breaking**] Allow registry specification in `run_dump` ([#1501](#1501)) - [**breaking**] Add `Package::validate` and return `ExtensionRegistry` in helpers. ([#1507](#1507)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/).
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 8, 2024
## 🤖 New release * `hugr`: 0.12.1 -> 0.13.0 (✓ API compatible changes) * `hugr-core`: 0.9.1 -> 0.10.0 (✓ API compatible changes) * `hugr-passes`: 0.8.1 -> 0.8.2 (✓ API compatible changes) * `hugr-cli`: 0.6.0 -> 0.6.1 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> ## `hugr` <blockquote> ## 0.13.0 (2024-10-08) ### Bug Fixes - [**breaking**] Make list length op give back the list ([#1547](#1547)) ### Features - [**breaking**] Allow CustomConsts to (optionally) be hashable ([#1397](#1397)) - Add an `OpLoadError` variant of `BuildError`. ([#1537](#1537)) - [**breaking**] `HugrMut::remove_node` and `SimpleReplacement` return removed weights ([#1516](#1516)) - Draft for `hugr-model` with export, import, parsing and pretty printing ([#1542](#1542)) </blockquote> ## `hugr-core` <blockquote> ## 0.10.0 (2024-10-08) ### Bug Fixes - [**breaking**] Make list length op give back the list ([#1547](#1547)) ### Features - [**breaking**] Allow CustomConsts to (optionally) be hashable ([#1397](#1397)) - Add an `OpLoadError` variant of `BuildError`. ([#1537](#1537)) - [**breaking**] `HugrMut::remove_node` and `SimpleReplacement` return removed weights ([#1516](#1516)) - Draft for `hugr-model` with export, import, parsing and pretty printing ([#1542](#1542)) </blockquote> ## `hugr-passes` <blockquote> ## 0.8.1 (2024-09-04) ### Features - Op replacement and lowering functions ([#1509](#1509)) </blockquote> ## `hugr-cli` <blockquote> ## 0.6.0 (2024-09-04) ### Features - [**breaking**] Allow registry specification in `run_dump` ([#1501](#1501)) - [**breaking**] Add `Package::validate` and return `ExtensionRegistry` in helpers. ([#1507](#1507)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/).
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offer simple interfaces for bulk lowering operations.
replace_opsprovided on top of lowering as replacing individual ops is much more efficient than splicing in subgraphs.