chore!: bump hugr version to 0.10.0 #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doug-q
force-pushed
the
doug/draft-bump-hugr-no-custom-type-arg
branch
from
d52fe98
to
ba3e2c6
Compare
doug-q
changed the title
doug-q
changed the title
We remove the cli of tket2-hseries, as the upstream API has changed and we no longer expect to use this.
doug-q
force-pushed
the
doug/draft-bump-hugr-no-custom-type-arg
branch
from
70adc7a
to
7f564c4
Compare
aborgna-q
reviewed
Jul 25, 2024
| return Err(serde_yaml::Error::custom( | ||
| "Opaque TKET1 operation did not have a yaml-encoded type argument.", | ||
| ) | ||
| .into()); | ||
| }; | ||
| let op = serde_yaml::from_value(arg.value.clone())?; | ||
| let op = serde_yaml::from_str(arg)?; |
There was a problem hiding this comment.
Suggested change
| let op = serde_yaml::from_str(arg)?; | |
| let op = serde_json::from_str(arg)?; |
You will also have to replace _yaml by _json in the custom error a couple lines above, and serde_yaml::Error with serde_json::Error in the OpConvertError definition on serialize/pytket.rs:213
There was a problem hiding this comment.
After that we should be able to drop the serde_yaml dependency.
|
We also need to recompile the included ECC sets because of the breaking serialisation version bump. |
aborgna-q
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #508 +/- ##
===========================================
+ Coverage 83.49% 96.73% +13.23%
===========================================
Files 64 17 -47
Lines 6648 521 -6127
Branches 6127 0 -6127
===========================================
- Hits 5551 504 -5047
+ Misses 817 17 -800
+ Partials 280 0 -280
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
aborgna-q
approved these changes
Jul 29, 2024
Cargo.toml
Outdated
There was a problem hiding this comment.
Drop serde_yaml from here too
This was referenced Jul 29, 2024
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 1, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>tket2-py: 0.2.0</summary> ## [0.2.0](tket2-py-v0.1.0...tket2-py-v0.2.0) (2024-08-01) ### ⚠ BREAKING CHANGES * increased minimum required version of hugr to 0.9.0 * `.rwr` ECC files generated with older versions are no longer supported. Please recompile them, or compress the file with `zstd`. ### Features * Add timeout options and stats to Badger ([#496](#496)) ([32a9885](32a9885)) * Compress binary ECCs using zlib ([#498](#498)) ([d9a713c](d9a713c)) * Expose advanced Badger timeout options to tket2-py ([#506](#506)) ([fe7d40e](fe7d40e)) * Move the compiled eccs to a separate package ([#517](#517)) ([7247cc6](7247cc6)) ### Bug Fixes * Recompile ecc sets after [#441](#441) ([#484](#484)) ([1122fa4](1122fa4)) ### Miscellaneous Chores * bump hugr version to 0.10.0 ([#508](#508)) ([eca258b](eca258b)) </details> <details><summary>tket2-eccs: 0.1.0</summary> ## 0.1.0 (2024-08-01) ### Features * Move the compiled eccs to a separate package ([#517](#517)) ([7247cc6](7247cc6)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Agustín Borgna <121866228+aborgna-q@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We remove the cli of tket2-hseries, as the upstream API has changed and
we no longer expect to use this.
BREAKING CHANGE: increased minimum required version of hugr to 0.9.0