-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: bump hugr version to 0.10.0 #508
Conversation
d52fe98
to
ba3e2c6
Compare
We remove the cli of tket2-hseries, as the upstream API has changed and we no longer expect to use this.
70adc7a
to
7f564c4
Compare
return Err(serde_yaml::Error::custom( | ||
"Opaque TKET1 operation did not have a yaml-encoded type argument.", | ||
) | ||
.into()); | ||
}; | ||
let op = serde_yaml::from_value(arg.value.clone())?; | ||
let op = serde_yaml::from_str(arg)?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let op = serde_yaml::from_str(arg)?; | |
let op = serde_json::from_str(arg)?; |
You will also have to replace _yaml
by _json
in the custom error a couple lines above, and serde_yaml::Error
with serde_json::Error
in the OpConvertError
definition on serialize/pytket.rs:213
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After that we should be able to drop the serde_yaml
dependency.
We also need to recompile the included ECC sets because of the breaking serialisation version bump. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #508 +/- ##
===========================================
+ Coverage 83.49% 96.73% +13.23%
===========================================
Files 64 17 -47
Lines 6648 521 -6127
Branches 6127 0 -6127
===========================================
- Hits 5551 504 -5047
+ Misses 817 17 -800
+ Partials 280 0 -280
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Cargo.toml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drop serde_yaml
from here too
🤖 I have created a release *beep* *boop* --- <details><summary>tket2-py: 0.2.0</summary> ## [0.2.0](tket2-py-v0.1.0...tket2-py-v0.2.0) (2024-08-01) ### ⚠ BREAKING CHANGES * increased minimum required version of hugr to 0.9.0 * `.rwr` ECC files generated with older versions are no longer supported. Please recompile them, or compress the file with `zstd`. ### Features * Add timeout options and stats to Badger ([#496](#496)) ([32a9885](32a9885)) * Compress binary ECCs using zlib ([#498](#498)) ([d9a713c](d9a713c)) * Expose advanced Badger timeout options to tket2-py ([#506](#506)) ([fe7d40e](fe7d40e)) * Move the compiled eccs to a separate package ([#517](#517)) ([7247cc6](7247cc6)) ### Bug Fixes * Recompile ecc sets after [#441](#441) ([#484](#484)) ([1122fa4](1122fa4)) ### Miscellaneous Chores * bump hugr version to 0.10.0 ([#508](#508)) ([eca258b](eca258b)) </details> <details><summary>tket2-eccs: 0.1.0</summary> ## 0.1.0 (2024-08-01) ### Features * Move the compiled eccs to a separate package ([#517](#517)) ([7247cc6](7247cc6)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Agustín Borgna <121866228+aborgna-q@users.noreply.github.com>
We remove the cli of tket2-hseries, as the upstream API has changed and
we no longer expect to use this.
BREAKING CHANGE: increased minimum required version of hugr to 0.9.0