Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Recompile ecc sets after #441 #484

Merged
merged 2 commits into from
Jul 15, 2024
Merged

fix: Recompile ecc sets after #441 #484

merged 2 commits into from
Jul 15, 2024

Conversation

aborgna-q
Copy link
Collaborator

@aborgna-q aborgna-q commented Jul 15, 2024 •
edited
Loading

The sets had to be updated after the changes in #441. Fixes #483

@aborgna-q aborgna-q requested a review from lmondada July 15, 2024 10:07
@aborgna-q aborgna-q requested a review from a team as a code owner July 15, 2024 10:07
@codecov Codecov
Copy link

codecov bot commented Jul 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.98%. Comparing base (e6f1adb) to head (ad1ad18).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #484      +/-   ##
==========================================
+ Coverage   81.94%   81.98%   +0.03%     
==========================================
  Files          61       61              
  Lines        6071     6072       +1     
  Branches     5550     5551       +1     
==========================================
+ Hits         4975     4978       +3     
+ Misses        835      833       -2     
  Partials      261      261
Flag Coverage Δ
python 96.73% <ø> (ø)
rust 80.59% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lmondada
lmondada approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@lmondada lmondada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe add a test that checks that badger_pass does "something", e.g. put a simple CX + CX circuit and see if badger cancels them out.

@aborgna-q
Copy link
Collaborator Author

nam_6_3 takes >100ms to load on CI, so it's a bit annoying to use in a test.
But we may be able to test small_eccs

@aborgna-q aborgna-q added this pull request to the merge queue Jul 15, 2024
Merged via the queue into main with commit 1122fa4 Jul 15, 2024
16 checks passed
@aborgna-q aborgna-q deleted the ab/update-eccs branch July 15, 2024 10:55
This was referenced Jul 15, 2024
Merged
Closed
github-merge-queue bot pushed a commit that referenced this pull request Jul 15, 2024
@hugrbot @aborgna-q
chore(main): release tket2-py 0.1.0a4 (#485)
a83a1af 
🤖 I have created a release *beep* *boop*
---


##
[0.1.0a4](tket2-py-v0.1.0...tket2-py-v0.1.0a4)
(2024-07-15)


### Bug Fixes

* Recompile ecc sets after
[#441](#441)
([#484](#484))
([1122fa4](1122fa4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: Agustin Borgna <agustin.borgna@quantinuum.com>
This was referenced Aug 1, 2024
Merged
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 1, 2024
@hugrbot @aborgna-q
chore(py): release (#518)
3959fc9 
🤖 I have created a release *beep* *boop*
---


<details><summary>tket2-py: 0.2.0</summary>

##
[0.2.0](tket2-py-v0.1.0...tket2-py-v0.2.0)
(2024-08-01)


### ⚠ BREAKING CHANGES

* increased minimum required version of hugr to 0.9.0
* `.rwr` ECC files generated with older versions are no longer
supported. Please recompile them, or compress the file with `zstd`.

### Features

* Add timeout options and stats to Badger
([#496](#496))
([32a9885](32a9885))
* Compress binary ECCs using zlib
([#498](#498))
([d9a713c](d9a713c))
* Expose advanced Badger timeout options to tket2-py
([#506](#506))
([fe7d40e](fe7d40e))
* Move the compiled eccs to a separate package
([#517](#517))
([7247cc6](7247cc6))


### Bug Fixes

* Recompile ecc sets after
[#441](#441)
([#484](#484))
([1122fa4](1122fa4))


### Miscellaneous Chores

* bump hugr version to 0.10.0
([#508](#508))
([eca258b](eca258b))
</details>

<details><summary>tket2-eccs: 0.1.0</summary>

## 0.1.0 (2024-08-01)


### Features

* Move the compiled eccs to a separate package
([#517](#517))
([7247cc6](7247cc6))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: Agustín Borgna <121866228+aborgna-q@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this pull request Aug 1, 2024
@hugrbot @doug-q
chore: release (#519)
248591b 
## 🤖 New release
* `tket2`: 0.1.0-alpha.2 -> 0.1.0
* `tket2-hseries`: 0.1.0

<details><summary><i><b>Changelog</b></i></summary><p>

## `tket2`
<blockquote>

##
[0.1.0](tket2-v0.1.0-alpha.2...tket2-v0.1.0)
- 2024-08-01

### Bug Fixes
- Single source of truth for circuit names, and better circuit errors
([#390](#390))
- Support non-DFG circuits
([#391](#391))
- Portmatching not matching const edges
([#444](#444))
- Pattern matcher discriminating on opaqueOp description
([#441](#441))
- `extract_dfg` inserting the output node with an invalid child order
([#442](#442))
- Recompile ecc sets after
[#441](#441)
([#484](#484))

### Documentation
- Update tket2-py readme
([#431](#431))
- Better error reporting in portmatching
([#437](#437))
- Improved multi-threading docs for Badger
([#495](#495))

### New Features
- `Circuit::operations` ([#395](#395))
- tuple unpack rewrite ([#406](#406))
- guppy → pytket conversion
([#407](#407))
- Drop linear bits, improve pytket encoding/decoding
([#420](#420))
- *(py)* Allow using `Tk2Op`s in the builder
([#436](#436))
- Initial support for `TailLoop` as circuit parent
([#417](#417))
- Support tuple unpacking with multiple unpacks
([#470](#470))
- Partial tuple unpack ([#475](#475))
- [**breaking**] Compress binary ECCs using zlib
([#498](#498))
- Add timeout options and stats to Badger
([#496](#496))
- Expose advanced Badger timeout options to tket2-py
([#506](#506))

### Refactor
- [**breaking**] Simplify tket1 conversion errors
([#408](#408))
- Cleanup tket1 serialized op structures
([#419](#419))

### Testing
- Add coverage for Badger split circuit multi-threading
([#505](#505))
</blockquote>

## `tket2-hseries`
<blockquote>

##
[0.1.0](https://github.com/CQCL/tket2/releases/tag/tket2-hseries-v0.1.0)
- 2024-08-01

### New Features
- [**breaking**] init tket2-hseries
([#368](#368))
- *(tket2-hseries)* Add `tket2.futures` Hugr extension
([#471](#471))
- Add lazify-measure pass
([#482](#482))
- add results extensions
([#494](#494))
- *(tket2-hseries)* [**breaking**] Add `HSeriesPass`
([#487](#487))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

---------

Co-authored-by: Douglas Wilson <douglas.wilson@quantinuum.com>
@hugrbot hugrbot mentioned this pull request Aug 5, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 15, 2024
@hugrbot @ss2165
chore: release (#521)
2a547c8 
## 🤖 New release
* `tket2`: 0.1.0 -> 0.1.1
* `tket2-hseries`: 0.1.0 -> 0.1.1

<details><summary><i><b>Changelog</b></i></summary><p>

## `tket2`
<blockquote>

##
[0.1.0](tket2-v0.1.0-alpha.2...tket2-v0.1.0)
- 2024-08-01

### Bug Fixes
- Single source of truth for circuit names, and better circuit errors
([#390](#390))
- Support non-DFG circuits
([#391](#391))
- Portmatching not matching const edges
([#444](#444))
- Pattern matcher discriminating on opaqueOp description
([#441](#441))
- `extract_dfg` inserting the output node with an invalid child order
([#442](#442))
- Recompile ecc sets after
[#441](#441)
([#484](#484))

### Documentation
- Update tket2-py readme
([#431](#431))
- Better error reporting in portmatching
([#437](#437))
- Improved multi-threading docs for Badger
([#495](#495))

### New Features
- `Circuit::operations` ([#395](#395))
- tuple unpack rewrite ([#406](#406))
- guppy → pytket conversion
([#407](#407))
- Drop linear bits, improve pytket encoding/decoding
([#420](#420))
- *(py)* Allow using `Tk2Op`s in the builder
([#436](#436))
- Initial support for `TailLoop` as circuit parent
([#417](#417))
- Support tuple unpacking with multiple unpacks
([#470](#470))
- Partial tuple unpack ([#475](#475))
- [**breaking**] Compress binary ECCs using zlib
([#498](#498))
- Add timeout options and stats to Badger
([#496](#496))
- Expose advanced Badger timeout options to tket2-py
([#506](#506))

### Refactor
- [**breaking**] Simplify tket1 conversion errors
([#408](#408))
- Cleanup tket1 serialized op structures
([#419](#419))

### Testing
- Add coverage for Badger split circuit multi-threading
([#505](#505))
</blockquote>

## `tket2-hseries`
<blockquote>

##
[0.1.1](tket2-hseries-v0.1.0...tket2-hseries-v0.1.1)
- 2024-08-15

### New Features
- *(tket2-hseries)* make result operation internals public
([#542](#542))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

---------

Co-authored-by: Seyon Sivarajah <seyon.sivarajah@cambridgequantum.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmondada lmondada lmondada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default rewrite set for badger does not match any pattern
2 participants
@aborgna-q @lmondada