-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Collab Page #52
Merged
Merged
Add Collab Page #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add new POST `questions/delete` endpoint * Update question service README * Update frontend to use new endpoint
to fit smaller viewports
This reverts commit cb11b5a.
Previously, the content of the question-box gets cut off when the panel is resized to a very small size
Closed
* collab-page-1: Integrate collab service Add confirm dialog box for submit and forfeit buttons Fix styling issue Update to set cursor position Update question-box to fetch question through API call Update chip colours to match difficulty Update layout styling Add codemirror Set up layout for question box and editor Update return type of getQuestionByID Revert "Update return type of getQuestionByID" Update return type of getQuestionByID Fix comments Fix question README Ensure question table is responsive Wrap delete questions in single API call
- Added a README.md to document the collaboration service. - Added a Dockerfile and docker-compose configuration to containerize the collaboration service. - Moved project files into appropriate directories for better structure and organization. - Updated helper.ts with improvements and new helper methods. - Refactored code to use the helper methods in helper.ts for consistency and reusability. - Removed unused tests.html file (will develop a new testing approach for HTML files in the future).
- Updated .env.sample to include MONGO_URI for MongoDB Atlas. - Modified mongodbservice.ts to use MONGO_URI for database connection. - Updated docker-compose.yml to pass MONGO_URI as an environment variable for the collaboration service.
- compose.dev.yml: Add port 8084 - compose.yml: Remove port 8084 - api.config.ts: Change to api gateway - editor.component.ts: Change the websocketurl - default.conf: Add the proxy - package.json: Add --files to solves issue on dev - index.ts: Edit the file sequence
samuelim01
reviewed
Oct 30, 2024
- Use Linting to fix - webSocketService.ts: Add new checks - editor.component.ts: Parse userid in the params
This error seems to be due to YJS attempting to read strings sent by the collab service. Let's keep the websocket channel purely for YJS-related changes.
samuelim01
force-pushed
the
collab-page
branch
from
October 30, 2024 15:51
97157ca
to
e5f9e75
Compare
This was referenced Oct 30, 2024
and produce QuestionFoundEvent, MatchFailedEvent
The finding match component could poll the status of the previous match request before the matchId updating to the new match request. Let's create a delay before the first poll to prevent this.`
samuelim01
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
McNaBry
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ensure that a user cannot query for rooms not belonging to them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a page for collaboration. This page contains the components for the editor and question box.
I have currently limited the support for the CodeMirror's syntax highlighter to java only as the prettier API, for code formatting, does not have plugins for other popular languages such as python, C++, and etc.
Checklist
Screenshots (if applicable)