Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I LOVE CIRCLES (heartbeat widget) #108

Merged
merged 12 commits into from
Feb 10, 2024
Merged

I LOVE CIRCLES (heartbeat widget) #108

merged 12 commits into from
Feb 10, 2024

Conversation

InvincibleRMC
Copy link
Member

Pull Request

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Add Circles to the gui.

Related Tickets & Documents

#71

@InvincibleRMC InvincibleRMC added the enhancement New feature or request label Feb 6, 2024
@InvincibleRMC InvincibleRMC self-assigned this Feb 6, 2024
@InvincibleRMC InvincibleRMC linked an issue Feb 6, 2024 that may be closed by this pull request
@InvincibleRMC
Copy link
Member Author

@NoahMollerstuen Your custom styles don't seem to work when running the guis as a node.

@NoahMollerstuen
Copy link
Contributor

@NoahMollerstuen Your custom styles don't seem to work when running the guis as a node.

What do you mean by that? Styles aren't applied at all, the custom styles aren't applied (but you get dark theme?) or you just can't change the theme? How exactly are you starting the node?

@InvincibleRMC
Copy link
Member Author

When I use ros2 run gui run_pilot or run_operator it runs the guis in lightmode but no custom coloration.

@NoahMollerstuen
Copy link
Contributor

The default theme only exists in the launch file. If you launch it with no theme you just get the default qdarktheme light theme. Maybe it should explicitly default to dark theme in app.py, idk.

src/surface/gui/gui/widgets/circle.py Outdated Show resolved Hide resolved
src/surface/gui/gui/widgets/circle.py Outdated Show resolved Hide resolved
src/surface/gui/gui/widgets/circle.py Outdated Show resolved Hide resolved
src/surface/gui/gui/styles/custom_styles.py Outdated Show resolved Hide resolved
src/surface/gui/gui/widgets/circle.py Outdated Show resolved Hide resolved
src/surface/gui/gui/widgets/circle.py Outdated Show resolved Hide resolved
src/surface/gui/gui/widgets/heartbeat.py Outdated Show resolved Hide resolved
@InvincibleRMC InvincibleRMC merged commit f6da050 into main Feb 10, 2024
1 check passed
@InvincibleRMC InvincibleRMC deleted the heartbeat-widget branch February 10, 2024 19:04
NoahMollerstuen pushed a commit that referenced this pull request May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Pi Heartbeat PyQt Widget
3 participants