Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vehicle State Manager #71

Merged
merged 73 commits into from
Feb 3, 2024
Merged

Vehicle State Manager #71

merged 73 commits into from
Feb 3, 2024

Conversation

NoahMollerstuen
Copy link
Contributor

@NoahMollerstuen NoahMollerstuen commented Nov 27, 2023

Pull Request

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Creates a new node on the pi called "pi_heartbeat", which sends a message to the surface twice a second. Also creates a new node on the surface which reads these messages and mavros state messages, and notifies surface nodes when the pi or pixhawk connects or disconnects, or the pixhawk is armed or disarmed. The arm button widget is updated to subscribe to these new messages and change its color when the vehicle state changes, to indicate whether the vehicle is disconnected, armed, or disarmed. To support this, the gui themeing system is updated to use qss files to define classes that can be dynamically applied to widgets at runtime.

Related Tickets & Documents

@NoahMollerstuen NoahMollerstuen changed the title Thruster testing Vehicle State Manager Dec 9, 2023
@NoahMollerstuen NoahMollerstuen marked this pull request as ready for review December 9, 2023 21:48
Copy link
Member

@InvincibleRMC InvincibleRMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only checked like 3 files

.gitmodules Outdated
@@ -1,3 +0,0 @@
[submodule "src/surface/ros2_video_streamer"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add back

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added back, I think. Please double check

src/pi/heartbeat/launch/heartbeat_launch.py Outdated Show resolved Hide resolved
@InvincibleRMC
Copy link
Member

Also update the dependabot.yml pls

Copy link
Contributor

@benjaminwp18 benjaminwp18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the test_copyright.pys (they test for copyright in every file - blegh) and add mypy tests to each package

src/pi/heartbeat/package.xml Outdated Show resolved Hide resolved
src/pi/heartbeat/package.xml Outdated Show resolved Hide resolved
src/pi/heartbeat/setup.py Outdated Show resolved Hide resolved
src/pi/pixhawk_communication/launch/mavros_launch.py Outdated Show resolved Hide resolved
src/rov_msgs/msg/VehicleState.msg Outdated Show resolved Hide resolved
src/surface/gui/gui/app.py Outdated Show resolved Hide resolved
src/surface/gui/gui/widgets/arm.py Outdated Show resolved Hide resolved
src/surface/vehicle_manager/package.xml Outdated Show resolved Hide resolved
src/surface/gui/gui/app.py Outdated Show resolved Hide resolved
src/surface/gui/gui/styles/customStyles.py Outdated Show resolved Hide resolved
src/surface/gui/gui/widgets/arm.py Outdated Show resolved Hide resolved
src/surface/gui/gui/widgets/thruster_tester.py Outdated Show resolved Hide resolved
PROPERTY_NAME: str


class WidgetState(Style):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add docstrings for WidgetState and Style

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@InvincibleRMC InvincibleRMC dismissed their stale review February 2, 2024 01:32

My changes done

@NoahMollerstuen NoahMollerstuen merged commit 2efca02 into main Feb 3, 2024
1 check passed
@NoahMollerstuen NoahMollerstuen deleted the thruster-testing branch February 3, 2024 21:29
@InvincibleRMC InvincibleRMC mentioned this pull request Feb 12, 2024
5 tasks
NoahMollerstuen added a commit that referenced this pull request May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Visual indication of armed status in the Arm widget
3 participants