Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GUIEventClient #72

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Fix GUIEventClient #72

merged 2 commits into from
Nov 27, 2023

Conversation

benjaminwp18
Copy link
Contributor

Pull Request

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Race conditions & string concatenation

InvincibleRMC
InvincibleRMC approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@InvincibleRMC InvincibleRMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@InvincibleRMC InvincibleRMC merged commit f7cd10c into main Nov 27, 2023
1 check passed
@InvincibleRMC InvincibleRMC deleted the fix-michael-nonsense branch November 27, 2023 22:13
NoahMollerstuen pushed a commit that referenced this pull request May 18, 2024
@InvincibleRMC
Merge pull request #72 from cwruRobotics/fix-michael-nonsense
78efa2d 
Fix GUIEventClient
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@InvincibleRMC InvincibleRMC InvincibleRMC approved these changes

Assignees

@benjaminwp18 benjaminwp18

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjaminwp18 @InvincibleRMC