Fixing Regression from #5819 and issue #5847 Timespan Settings

* In issue #5819 we introduced a new feature to match the predefined timespans with the Cacti data collector, however, the read_config_option for the poller last run timespan was not read from the database every pass, causing the timespan not to update. This fix resolves that regression.
Cacti · Oct 12, 2024 · 80d013a · 80d013a
1 parent c9dc820
commit 80d013a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG b/CHANGELOG
@@ -2,6 +2,7 @@ Cacti CHANGELOG
 
 1.2.x
 -issue#5843: Issue with temporary tables with use of microtime
+-issue#5847: Presets Time in Cacti 1.2.28 Not Automatically Updating...
 
 1.2.28
 -security#GHSA-49f2-hwx9-qffr: XSS vulnerability when creating external links with the consolenewsection parameter

diff --git a/lib/timespan_settings.php b/lib/timespan_settings.php
@@ -192,7 +192,7 @@ function set_preset_timespan(&$timespan) {
 
 	/* operate like graphs if graphs is set */
 	if ($graph) {
-		$time = read_config_option('poller_lastrun_1');
+		$time = read_config_option('poller_lastrun_1', true);
 
 		if (empty($time)) {
 			$time = time();
-Original file line number
+Diff line change
@@ Expand Up / @@ -2,6 +2,7 @@ Cacti CHANGELOG @@
 .2.x
     -issue#5843: Issue with temporary tables with use of microtime
+    -issue#5847: Presets Time in Cacti 1.2.28 Not Automatically Updating...
 .2.28
     -security#GHSA-49f2-hwx9-qffr: XSS vulnerability when creating external links with the consolenewsection parameter
@@ Expand Down @@