Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When displaying graphs, default end time does not show full 24 hour period #5819

Closed
dmitry-moiseenko opened this issue Sep 9, 2024 · 6 comments
Closed

When displaying graphs, default end time does not show full 24 hour period #5819

dmitry-moiseenko opened this issue Sep 9, 2024 · 6 comments
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Milestone
1.2.28

Comments

@dmitry-moiseenko
Copy link

graph_cacti

Describe the bug

Console -> Management -> Graphs and select any graph, it opens, but the time is always 5 minutes behind the current time (I mean the last point on the graph).

In my understanding, it should automatically display a 24-hour interval, but in reality, it always shows 23:55.

Cacti Version 1.2.27
Oracle Linux 9
@dmitry-moiseenko dmitry-moiseenko added bug Undesired behaviour unverified Some days we don't have a clue labels Sep 9, 2024
@TheWitness
Copy link
Member

This is correct. We may be well served by re-evaluating this. We try to ensure we don't get the gaps at the end, but if you are polling at 30 seconds, it can be annoying.

@dmitry-moiseenko
Copy link
Author

No, we do polling once a minute. We also use the weathermap plugin, and the delay is a bit annoying. It would be great if this could be re-evaluated.

TheWitness added a commit that referenced this issue Sep 12, 2024
@TheWitness
Fixing #5819 - End Time Calculation Precision
4237f86 
Be more precise on the Graph End time when an end time is not provided
@TheWitness TheWitness changed the title Graph is 5 minutes late Be more precise on the Graph End time when an end time is not provided Sep 12, 2024
@TheWitness
Copy link
Member

@dmitry-moiseenko , please try the latest lib/rrd.php

TheWitness added a commit that referenced this issue Sep 12, 2024
@TheWitness
QA: #5819 - Minor tweak to timespan settings
2a012b2
@TheWitness
Copy link
Member

@dmitry-moiseenko, I just made another small tweak for the timespan selector. Looking good now there.

TheWitness added a commit that referenced this issue Sep 12, 2024
@TheWitness
Fixing #5819 - End Time Calculation Precision
25c90f2 
Be more precise on the Graph End time when an end time is not provided
TheWitness added a commit that referenced this issue Sep 12, 2024
@TheWitness
QA: #5819 - Minor tweak to timespan settings
28d5c4a
@TheWitness TheWitness added resolved A fixed issue confirmed Bug is confirm by dev team and removed unverified Some days we don't have a clue labels Sep 12, 2024
@TheWitness TheWitness added this to the 1.2.28 milestone Sep 12, 2024
@dmitry-moiseenko
Copy link
Author

Thank you so much for that fix. It works perfectly!

@TheWitness
Copy link
Member

Perfect @dmitry-moiseenko. Thanks for inspiring me to make the change.

@netniV netniV changed the title Be more precise on the Graph End time when an end time is not provided When display graphs, end time does not show full 24 hour period Sep 29, 2024
@netniV netniV changed the title When display graphs, end time does not show full 24 hour period When displaying graphs, default end time does not show full 24 hour period Sep 29, 2024
TheWitness added a commit that referenced this issue Oct 12, 2024
@TheWitness
Fixing Regression from #5819 and issue #5847 Timespan Settings
80d013a 
* In issue #5819 we introduced a new feature to match the predefined timespans with the Cacti data collector, however, the read_config_option for the poller last run timespan was not read from the database every pass, causing the timespan not to update.  This fix resolves that regression.
TheWitness added a commit that referenced this issue Oct 12, 2024
@TheWitness
Fixing Regression from #5819 and issue #5847 Timespan Settings
e6db113 
* In issue #5819 we introduced a new feature to match the predefined timespans with the Cacti data collector, however, the read_config_option for the poller last run timespan was not read from the database every pass, causing the timespan not to update.  This fix resolves that regression.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Projects
None yet
Milestone
1.2.28
Development

No branches or pull requests
2 participants
@TheWitness @dmitry-moiseenko