Skip to content

Commit

Permalink
Fixing Regression from #5819 and issue #5847 Timespan Settings
Browse files Browse the repository at this point in the history
* In issue #5819 we introduced a new feature to match the predefined timespans with the Cacti data collector, however, the read_config_option for the poller last run timespan was not read from the database every pass, causing the timespan not to update.  This fix resolves that regression.
  • Loading branch information
TheWitness committed Oct 12, 2024
1 parent b6f8ca6 commit e6db113
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ Cacti CHANGELOG

1.2.29
-issue#5843: Issue with temporary tables with use of microtime
-issue#5847: Presets Time in Cacti 1.2.28 Not Automatically Updating...

1.2.28
-security#GHSA-49f2-hwx9-qffr: XSS vulnerability when creating external links with the consolenewsection parameter
Expand Down
2 changes: 1 addition & 1 deletion lib/timespan_settings.php
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ function set_preset_timespan(&$timespan) {

/* operate like graphs if graphs is set */
if ($graph) {
$time = read_config_option('poller_lastrun_1');
$time = read_config_option('poller_lastrun_1', true);

if (empty($time)) {
$time = time();
Expand Down

0 comments on commit e6db113

Please sign in to comment.