Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted C++ / SCons cleanup #1574

Merged
merged 9 commits into from
Aug 9, 2023

[Reactor] Remove vestigial ReactorSurface code from WallBase

3b30d09
Select commit
Loading
Failed to load commit list.
Merged

Assorted C++ / SCons cleanup #1574

[Reactor] Remove vestigial ReactorSurface code from WallBase
3b30d09
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Aug 9, 2023 in 1s

70.52% (-0.02%) compared to 25851e7

View this Pull Request on Codecov

70.52% (-0.02%) compared to 25851e7

Details

Codecov Report

Merging #1574 (3b30d09) into main (25851e7) will decrease coverage by 0.02%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main    #1574      +/-   ##
==========================================
- Coverage   70.53%   70.52%   -0.02%     
==========================================
  Files         379      379              
  Lines       59110    59118       +8     
  Branches    21232    21237       +5     
==========================================
- Hits        41695    41693       -2     
- Misses      14340    14352      +12     
+ Partials     3075     3073       -2     
Files Changed Coverage Δ
include/cantera/base/AnyMap.h 80.00% <ø> (ø)
include/cantera/base/Array.h 96.00% <ø> (+13.24%) ⬆️
include/cantera/base/ValueCache.h 100.00% <ø> (ø)
include/cantera/kinetics/InterfaceKinetics.h 87.50% <ø> (ø)
include/cantera/kinetics/Kinetics.h 32.66% <ø> (ø)
include/cantera/kinetics/ReactionPath.h 67.44% <ø> (ø)
include/cantera/kinetics/ThirdBodyCalc.h 98.38% <ø> (ø)
include/cantera/numerics/BandMatrix.h 0.00% <ø> (ø)
include/cantera/numerics/GeneralMatrix.h 15.38% <ø> (ø)
...nclude/cantera/thermo/CoverageDependentSurfPhase.h 100.00% <ø> (+32.00%) ⬆️
... and 14 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more