Relative path passed using join fails in pyrestcli if it has / at the beggining #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beggining pyrestcli uses urljoin to merge base_url and the relative_path but if the relative_path has / at the beggining, it overrides the current path in the base url and that's a problem if the base url is like https://carto.com/user/testuser so for example: base url: https://carto.com/user/testuser send path: /api/v3/endpoint the url used in the send method is going to be: https://carto.com/api/v3/endpoint removing the /user/carto path which is really important for us
alrocar
suggested changes
Oct 17, 2018
| @@ -17,7 +17,7 @@ | |||
| author="Daniel Carrión", | |||
| author_email="daniel@carto.com", | |||
| description="SDK around CARTO's APIs", | |||
| version="1.3.0", | |||
| version="1.3.1", | |||
There was a problem hiding this comment.
Since this is a new release could you please update the version in conf.py and NEWS.md? See the release process here
added 2 commits
October 17, 2018 18:49
|
@alrocar second 👁️ ? |
alrocar
approved these changes
Oct 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyrestcli uses urljoin to merge base_url and the relative_path but if
the relative_path has / at the beggining, it overrides the current path
in the base url and that's a problem if the base url is like
https://carto.com/user/testuser so for example:
base url: https://carto.com/user/testuser
send path: /api/v3/endpoint
the url used in the send method is going to be:
https://carto.com/api/v3/endpoint removing the /user/carto path which is
really important for us