Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix auth api problem due to a bug in the carto python library #493

Merged
merged 2 commits into from
Oct 18, 2018
Merged

Fix auth api problem due to a bug in the carto python library #493

merged 2 commits into from
Oct 18, 2018

Conversation

ethervoid
Copy link
Contributor

@ethervoid ethervoid requested a review from andy-esch October 18, 2018 08:54
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.128% when pulling b9eac00 on fix_subdomainless_auth_problem into 9c9b6c6 on master.

@coveralls
Copy link

coveralls commented Oct 18, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 97.128% when pulling b9eac00 on fix_subdomainless_auth_problem into 9c9b6c6 on master.

andy-esch
andy-esch approved these changes Oct 18, 2018
View reviewed changes
Copy link
Contributor

@andy-esch andy-esch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@andy-esch
Copy link
Contributor

... feel free to merge when ready!

@ethervoid ethervoid merged commit d0a9bda into master Oct 18, 2018
@ethervoid ethervoid deleted the fix_subdomainless_auth_problem branch October 18, 2018 13:52
@andy-esch andy-esch mentioned this pull request Oct 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy-esch andy-esch andy-esch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ethervoid @coveralls @andy-esch