Merge pull request #1690 from CartoDB/bug/ch100627/nikhita-stord-blan…

…k-popups-showing-for-a Fix strange behaviour with previoulsy open popups
CartoDB · Sep 18, 2020 · 445c7bb · 445c7bb
2 parents 8cf53f6 + 7dbbb1e
commit 445c7bb
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 10 deletions.
diff --git a/cartoframes/assets/src/bundle.js b/cartoframes/assets/src/bundle.js
@@ -581,12 +581,16 @@ var init = (function () {
         }
       }
 
-      popup
-          .setLngLat([event.coordinates.lng, event.coordinates.lat])
-          .setHTML(`<div class="popup-content">${popupHTML}</div>`);
+      if (popupHTML) {
+        popup
+            .setLngLat([event.coordinates.lng, event.coordinates.lat])
+            .setHTML(`<div class="popup-content">${popupHTML}</div>`);
 
-      if (popupHTML.length > 0 && !popup.isOpen()) {
-        popup.addTo(map);
+        if (!popup.isOpen()) {
+          popup.addTo(map);
+        }
+      } else {
+        popup.remove();
       }
     } else {
       popup.remove();

diff --git a/cartoframes/assets/src/map/popups.js b/cartoframes/assets/src/map/popups.js
@@ -47,12 +47,16 @@ export function updatePopup(map, popup, event, attrs) {
       }
     }
 
-    popup
-        .setLngLat([event.coordinates.lng, event.coordinates.lat])
-        .setHTML(`<div class="popup-content">${popupHTML}</div>`);
+    if (popupHTML) {
+      popup
+          .setLngLat([event.coordinates.lng, event.coordinates.lat])
+          .setHTML(`<div class="popup-content">${popupHTML}</div>`);
 
-    if (popupHTML.length > 0 && !popup.isOpen()) {
-      popup.addTo(map);
+      if (!popup.isOpen()) {
+        popup.addTo(map);
+      }
+    } else {
+      popup.remove();
     }
   } else {
     popup.remove();