Fix strange behaviour with previoulsy open popups #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jesus89
requested changes
Sep 18, 2020
cartoframes/assets/src/map/popups.js
Outdated
| @@ -51,9 +51,12 @@ export function updatePopup(map, popup, event, attrs) { | |||
| .setLngLat([event.coordinates.lng, event.coordinates.lat]) | |||
| .setHTML(`<div class="popup-content">${popupHTML}</div>`); | |||
|
|
|||
| if (popupHTML.length > 0 && !popup.isOpen()) { | |||
| if (!popup.isOpen()) { | |||
There was a problem hiding this comment.
I would avoid setting and adding, and removing the popup every time. We could try something like this instead:
if (popupHTML) {
popup
.setLngLat([event.coordinates.lng, event.coordinates.lat])
.setHTML(`<div class="popup-content">${popupHTML}</div>`);
if (!popup.isOpen()) {
popup.addTo(map);
}
} else {
popup.remove();
}
|
@Jesus89 new CR round? |
Jesus89
approved these changes
Sep 18, 2020
antoniocarlon
deleted the
bug/ch100627/nikhita-stord-blank-popups-showing-for-a
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix strange behaviour with previoulsy open popups