Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CATROID-1519 fixed unresolved imports in org.catrobat.catroid(test) file #4697

Merged
merged 1 commit into from
Mar 13, 2023
Merged

CATROID-1519 fixed unresolved imports in org.catrobat.catroid(test) file #4697

merged 1 commit into from
Mar 13, 2023

Conversation

Aayush2111
Copy link
Contributor

@Aayush2111 Aayush2111 commented Feb 22, 2023 •
edited
Loading

Jira ticket: https://jira.catrob.at/browse/CATROID-1519

Fixed unresolved imports in org.catrobat.catroid(test) file

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@Aayush2111
Copy link
Contributor Author

@sebastiangollob @mseiser
Please review the changes and provide any feedback that you may have.
Thank you! :)

sebastiangollob
sebastiangollob requested changes Feb 25, 2023
View reviewed changes
Copy link
Member

@sebastiangollob sebastiangollob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4703 (review)

@sebastiangollob
Copy link
Member

The issue is partly related to #4672

@mseiser
Copy link
Contributor

mseiser commented Mar 8, 2023

How to reproduce this issue?

@sebastiangollob
Copy link
Member

See also #4710 as it is a duplicate

@mseiser
Copy link
Contributor

mseiser commented Mar 8, 2023

See also #4710 as it is a duplicate

thanks 👍

@mseiser
Copy link
Contributor

mseiser commented Mar 8, 2023

merged with #4710

@mseiser mseiser closed this Mar 8, 2023
@mseiser mseiser reopened this Mar 13, 2023
@mseiser
Copy link
Contributor

mseiser commented Mar 13, 2023

reopened because issue still persited

@mseiser mseiser self-requested a review March 13, 2023 16:43
@mseiser mseiser merged commit 81d3ef4 into Catrobat:develop Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastiangollob sebastiangollob sebastiangollob approved these changes

@mseiser mseiser Awaiting requested review from mseiser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Aayush2111 @sebastiangollob @mseiser